Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modarith] Add a modarith type to describe storage type & modulus #1084

Open
asraa opened this issue Nov 11, 2024 · 3 comments · Fixed by #1088
Open

[modarith] Add a modarith type to describe storage type & modulus #1084

asraa opened this issue Nov 11, 2024 · 3 comments · Fixed by #1088

Comments

@asraa
Copy link
Collaborator

asraa commented Nov 11, 2024

This would remove the mod arith op attributes tracking the modulus.

We realized this would be a nice "type" to have to describe the coefficient type of a ring. In the case of working with $$\mathbb{Z}_q$$, the coefficient type would be a modarith type like modarith<type = i32, modulus = q>. RNS types would be a list of modarith types.

See the type refactor here: #1083

Copy link

Note

Re-commenting because this issue was closed with unresolved TODOs.

This issue has 1 outstanding TODOs:

This comment was autogenerated by todo-backlinks

1 similar comment
Copy link

Note

Re-commenting because this issue was closed with unresolved TODOs.

This issue has 1 outstanding TODOs:

This comment was autogenerated by todo-backlinks

@j2kun j2kun reopened this Nov 21, 2024
@j2kun
Copy link
Collaborator

j2kun commented Nov 21, 2024

Reopening for the remaining TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants