Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI with "expensive pattern checks" on #1068

Open
AlexanderViand-Intel opened this issue Oct 23, 2024 · 3 comments
Open

Run CI with "expensive pattern checks" on #1068

AlexanderViand-Intel opened this issue Oct 23, 2024 · 3 comments
Assignees

Comments

@AlexanderViand-Intel
Copy link
Collaborator

PXL_20241023_212452073.jpg

@AlexanderViand-Intel AlexanderViand-Intel self-assigned this Oct 23, 2024
@asraa
Copy link
Collaborator

asraa commented Oct 24, 2024

Nice! We already have an asan config at least!

@AlexanderViand-Intel
Copy link
Collaborator Author

Ok, I feel a bit dumb asking this, but how do I pass these kind of flags to the LLVM build from bazel? It seems like configure_llvm only has provisions for selecting targets, but no more general options?

@asraa
Copy link
Collaborator

asraa commented Oct 24, 2024

I think you might need to test this since I'm not totally certain but the easiest way would be to create a build configuration in the bazelrc like

build:expensive --copt -DMLIR_ENABLE_EXPENSIVE
build:expensive --config asan

So if you run any build with bazel build --config expensive then it would enable the asan flags and the macro.

I think that's at least how I'd work around the configure_llvm limitation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants