Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

> Of course, that would be incompatible with one of the possible approaches to https://github.com/google/guava/issues/3990, which is to use --release. #6550

Closed
cpovirk opened this issue Jun 13, 2023 · 0 comments

Comments

@cpovirk
Copy link
Member

cpovirk commented Jun 13, 2023

          > Of course, that would be incompatible with one of the possible approaches to https://github.com/google/guava/issues/3990, which is to use `--release`.

Well, not completely: We could use --release 8 but then perform a second compilation with (e.g.) --release 11 to put a second set of classes into a multi-release jar. Even though multi-release jars don't do one of the things we might like, I think they could work well here. We could even imagine conditionally using APIs like CRC32C internally by providing an exception-throwing implementation for Java 8 in addition to a "real" implementation for newer versions and then making sure to perform appropriate checks before using the implementation class.

Originally posted by @cpovirk in #6549 (comment)

@cpovirk cpovirk closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant