From 280b5d2f606b5f37304d728311cf492d45f95843 Mon Sep 17 00:00:00 2001 From: cpovirk Date: Mon, 16 Oct 2023 14:26:09 -0700 Subject: [PATCH] Give `failureaccess` an `Automatic-Module-Name`, and bump its version to 1.0.2 to prepare for a release (which we'll then need to update Guava to use). I chose an `Automatic-Module-Name` over an actual `module-info`, even for this dependency-free artifact, because [I can do that without requiring JDK 9+ for builds](https://github.com/google/guava/issues/6549#issuecomment-1761753306). Granted, there would be relatively little harm in requiring JDK 9+ for `failureaccess` builds, since `failureaccess` isn't part of our normal build process. (Guava's build pulls an already released version of `failureaccess`.) Still, it's possible that someone is building both Guava _and_ `failureaccess` with JDK 8, so it may be nice not to break that workflow. Plus, I'm not sure that a proper module definition buys us much (relative to `Automatic-Module-Name`) when we have no deps? Still, I am a bit tempted, if only to try to shake out remaining issues that `module-info` might cause our users. This CL is progress toward fixing https://github.com/google/guava/issues/6776 (or "toward working around a Maven bug," if you prefer). It's also a tiny bit of progress toward modularizing Guava (https://github.com/google/guava/issues/2970), since `failureaccess` is one of its existing unmodularized dependencies. RELNOTES=Added an `Automatic-Module-Name` to `failureaccess`, [Guava's one strong runtime dependency](https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies). PiperOrigin-RevId: 573930127 --- futures/failureaccess/pom.xml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/futures/failureaccess/pom.xml b/futures/failureaccess/pom.xml index 47fe296dee0a..122c3e5ab972 100644 --- a/futures/failureaccess/pom.xml +++ b/futures/failureaccess/pom.xml @@ -8,7 +8,7 @@ 26.0-android failureaccess - 1.0.1 + 1.0.2 bundle Guava InternalFutureFailureAccess and InternalFutures @@ -22,6 +22,16 @@ + + maven-jar-plugin + + + + com.google.common.util.concurrent.internal + + + + maven-source-plugin