Skip to content

Commit

Permalink
Give failureaccess an Automatic-Module-Name, and bump its version…
Browse files Browse the repository at this point in the history
… to 1.0.2 to prepare for a release (which we'll then need to update Guava to use).

I chose an `Automatic-Module-Name` over an actual `module-info`, even for this dependency-free artifact, because [I can do that without requiring JDK 9+ for builds](#6549 (comment)). Granted, there would be relatively little harm in requiring JDK 9+ for `failureaccess` builds, since `failureaccess` isn't part of our normal build process. (Guava's build pulls an already released version of `failureaccess`.) Still, it's possible that someone is building both Guava _and_ `failureaccess` with JDK 8, so it may be nice not to break that workflow. Plus, I'm not sure that a proper module definition buys us much (relative to `Automatic-Module-Name`) when we have no deps? Still, I am a bit tempted, if only to try to shake out remaining issues that `module-info` might cause our users.

This CL is progress toward fixing #6776 (or "toward working around a Maven bug," if you prefer).

It's also a tiny bit of progress toward modularizing Guava (#2970), since `failureaccess` is one of its existing unmodularized dependencies.

RELNOTES=Added an `Automatic-Module-Name` to `failureaccess`, [Guava's one strong runtime dependency](https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies).
PiperOrigin-RevId: 573930127
  • Loading branch information
cpovirk authored and Google Java Core Libraries committed Oct 16, 2023
1 parent 5550ffc commit 280b5d2
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion futures/failureaccess/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<version>26.0-android</version>
</parent>
<artifactId>failureaccess</artifactId>
<version>1.0.1</version>
<version>1.0.2</version>
<packaging>bundle</packaging>
<name>Guava InternalFutureFailureAccess and InternalFutures</name>
<description>
Expand All @@ -22,6 +22,16 @@
</description>
<build>
<plugins>
<plugin>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>com.google.common.util.concurrent.internal</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
</plugin>
<plugin>
<artifactId>maven-source-plugin</artifactId>
</plugin>
Expand Down

0 comments on commit 280b5d2

Please sign in to comment.