From 1e65298271354943ef53ba9935e694dd98ec9284 Mon Sep 17 00:00:00 2001 From: xiaozhenliugg Date: Fri, 20 Mar 2020 10:44:25 -0700 Subject: [PATCH 1/4] no warning for todo comments --- .eslintrc.json | 1 + 1 file changed, 1 insertion(+) diff --git a/.eslintrc.json b/.eslintrc.json index 5dffe0c4..42e1797e 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -27,6 +27,7 @@ "rules": { "@typescript-eslint/no-non-null-assertion": "off", "@typescript-eslint/no-use-before-define": "off", + "@typescript-eslint/no-warning-comments": "off", "@typescript-eslint/explicit-function-return-type": "off", "@typescript-eslint/camelcase": "off", "node/no-missing-import": "off", From 920644093cbb860e5db05f1340115ade3b25eddf Mon Sep 17 00:00:00 2001 From: xiaozhenliugg Date: Fri, 20 Mar 2020 10:50:41 -0700 Subject: [PATCH 2/4] add more rules --- .eslintrc.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.eslintrc.json b/.eslintrc.json index 42e1797e..c542c377 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -30,9 +30,13 @@ "@typescript-eslint/no-warning-comments": "off", "@typescript-eslint/explicit-function-return-type": "off", "@typescript-eslint/camelcase": "off", + "@typescript-eslint/no-var-requires": "off", "node/no-missing-import": "off", + "node/no-empty-function": "off", "node/no-unsupported-features/es-syntax": "off", "node/no-missing-require": "off", + "node/no-unused-vars": "off", + "node/no-explicit-any": "off", "node/shebang": "off", "no-dupe-class-members": "off" }, From 7277f28add8643eebb063d86584becc64e723fb3 Mon Sep 17 00:00:00 2001 From: xiaozhenliugg Date: Fri, 20 Mar 2020 11:28:09 -0700 Subject: [PATCH 3/4] feedback --- .eslintrc.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index c542c377..1f1e116a 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -35,8 +35,6 @@ "node/no-empty-function": "off", "node/no-unsupported-features/es-syntax": "off", "node/no-missing-require": "off", - "node/no-unused-vars": "off", - "node/no-explicit-any": "off", "node/shebang": "off", "no-dupe-class-members": "off" }, From 89fa81f43348a5df773c14856d6db78e3ba0d07d Mon Sep 17 00:00:00 2001 From: xiaozhenliugg Date: Fri, 20 Mar 2020 11:28:32 -0700 Subject: [PATCH 4/4] feedback --- .eslintrc.json | 1 - 1 file changed, 1 deletion(-) diff --git a/.eslintrc.json b/.eslintrc.json index 1f1e116a..c4dbbab4 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -30,7 +30,6 @@ "@typescript-eslint/no-warning-comments": "off", "@typescript-eslint/explicit-function-return-type": "off", "@typescript-eslint/camelcase": "off", - "@typescript-eslint/no-var-requires": "off", "node/no-missing-import": "off", "node/no-empty-function": "off", "node/no-unsupported-features/es-syntax": "off",