Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use eslint instead of tslint #400

Merged
merged 3 commits into from
Jan 13, 2020
Merged

feat!: use eslint instead of tslint #400

merged 3 commits into from
Jan 13, 2020

Conversation

JustinBeckwith
Copy link
Collaborator

@JustinBeckwith JustinBeckwith commented Nov 26, 2019

BREAKING CHANGE: Switch from tslint to eslint. This will impact all lint rules, and tslint specific configuration.

src/cli.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that this is mostly a noop seems reasonable to consolidate on eslint:

  1. I'd love for us to check how the performance is on https://github.com/googleapis/google-api-nodejs-client, since this is the library that was bumping into memory issues linting.
  2. I'm curious as to why its own linting is failing.

@JustinBeckwith JustinBeckwith changed the title feat!: use eslint feat!: use eslint instead of tslint Jan 13, 2020
@JustinBeckwith JustinBeckwith merged commit b3096fb into master Jan 13, 2020
@JustinBeckwith JustinBeckwith deleted the eslint branch January 22, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants