Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android R8 issue with version 2.8.6 #1641

Closed
shubhambansal opened this issue Jan 16, 2020 · 3 comments
Closed

Android R8 issue with version 2.8.6 #1641

shubhambansal opened this issue Jan 16, 2020 · 3 comments

Comments

@shubhambansal
Copy link

I started getting the following error after updating to version 2.8.6. Until 2.8.5 everything works fine.

> Task :app:transformClassesAndResourcesWithR8ForBetaRelease FAILED
R8 is the new Android code shrinker. If you experience any issues, please file a bug at
https://issuetracker.google.com, using 'Shrinker (R8)' as component name. You can
disable R8 by updating gradle.properties with 'android.enableR8=false'.

.../transforms/FirebasePerformancePlugin/beta/release/66/module-info.class:
D8: Unsupported source file type 

gradle.properties configuration
android.enableR8.fullMode=true

@elirex
Copy link

elirex commented Apr 20, 2020

I have the same issue when used Android Gradle plugin v3.4.0 and Gradle v5.1.1 to build Apk. My workaround is Android Gradle plugin upgrades to 3.5.3 and Gradle upgrades to v5.5 then succeed to build Apk. But in build log still seen

Can't instrument module-info.class
java.lang.RuntimeException
        at org.objectweb.asm.ClassVisitor.visitModule(ClassVisitor.java:148)
        at org.objectweb.asm.ClassReader.readModule(ClassReader.java:731)
        at org.objectweb.asm.ClassReader.accept(ClassReader.java:632)
        at com.google.firebase.perf.plugin.instrumentation.Instrument.instrument(Instrument.java:151)
        at com.google.firebase.perf.plugin.instrumentation.Instrument.instrumentClassesInJar(Instrument.java:100)
...

@Marcono1234
Copy link
Collaborator

Marcono1234 commented Aug 12, 2022

Can you please check if this issue still occurs with the latest Gson version? The way the module-info.class file is included in the Gson JAR was changed and should hopefully now cause fewer issues. Also make sure to use the latest build tools and plugins (e.g. Gradle).

@Marcono1234
Copy link
Collaborator

I am going to close this because no answer has been provided. If you still experience this with the latest Gson version, feel free to comment here again with more details.

@Marcono1234 Marcono1234 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants