Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include an automatic module name in the manifest #1238

Closed
kashike opened this issue Jan 30, 2018 · 1 comment
Closed

Include an automatic module name in the manifest #1238

kashike opened this issue Jan 30, 2018 · 1 comment

Comments

@kashike
Copy link

kashike commented Jan 30, 2018

While #1179 adds a (broken) module-info.java, it is disabled. Adding an Automatic-Module-Name manifest entry will not break on previous versions of Java, and will allow gson to be used without becoming a full module.

Related:
google/guava#2846
google/guava#2961
vigna/fastutil#89 (comment)
@wimdeblauwe wimdeblauwe mentioned this issue Sep 10, 2019
Closed
@milleruntime milleruntime mentioned this issue Nov 20, 2019
Closed
@Marcono1234
Copy link
Collaborator

Probably obsolete now. The latest Gson versions contain a valid module-info.class, which additionally should (hopefully) also work well for Java versions < 9, see #2013.

(Also, hello kashike 👋)

@eamonnmcmanus eamonnmcmanus closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eamonnmcmanus @kashike @Marcono1234