Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code health] Add support for static type checking #5

Closed
gino-m opened this issue Nov 16, 2018 · 3 comments
Closed

[Code health] Add support for static type checking #5

gino-m opened this issue Nov 16, 2018 · 3 comments
Assignees
@gino-m
Labels
cloud functions Server-side Cloud Functions hosted in Firebase, including database triggers type: code health Improvements to readability or robustness of codebase web Angular implementation of Web UI
Milestone
G4G '19

Comments

@gino-m
Copy link
Collaborator

gino-m commented Nov 16, 2018

Possibly using Flow?
@gino-m gino-m added cloud functions Server-side Cloud Functions hosted in Firebase, including database triggers web Angular implementation of Web UI labels Nov 16, 2018
@gino-m gino-m added this to the Beta 1 milestone Nov 16, 2018
@gino-m gino-m self-assigned this Nov 16, 2018
@gino-m gino-m added web Angular implementation of Web UI and removed web Angular implementation of Web UI labels Nov 16, 2018
@gino-m gino-m changed the title [Code health] Add static type checking to existing codebase Add static type checking to existing codebase Nov 16, 2018
@gino-m gino-m added the type: code health Improvements to readability or robustness of codebase label Nov 16, 2018
@gino-m gino-m changed the title Add static type checking to existing codebase [Code health] Add static type checking to existing codebase Nov 18, 2018
@gino-m
Copy link
Collaborator Author

gino-m commented Nov 28, 2018

This guide looks like it could be helpful:
https://medium.freecodecamp.org/incrementally-add-flow-type-checking-react-261fee015f80

@gino-m gino-m changed the title [Code health] Add static type checking to existing codebase [Code health] Add support for static type checking Dec 8, 2018
@gino-m gino-m closed this as completed in f4c1b71 Dec 8, 2018
@gino-m
Copy link
Collaborator Author

gino-m commented Dec 8, 2018

Added support for Flow type checking npm run flow. Also verified type checking working with Atom package ide-flowtype (requires atom-ide-ui).

Was unable to add build-time checks due to facebook/create-react-app#1592. In the future, hopefully create-react-app will support running Flow at build-time (facebook/create-react-app#5995). If not, may consider "ejecting" create-react-app config and following this guide or similar to set up build-time type checking.

@gino-m
Copy link
Collaborator Author

gino-m commented Dec 11, 2018

Added followups #38 and #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gino-m gino-m

Labels
cloud functions Server-side Cloud Functions hosted in Firebase, including database triggers type: code health Improvements to readability or robustness of codebase web Angular implementation of Web UI
Projects
None yet
Milestone
G4G '19
Development

No branches or pull requests
1 participant
@gino-m