Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data collection] "Other" multiple choice option with no text not saved #2846

Open
gino-m opened this issue Nov 18, 2024 · 0 comments
Open
Labels
type: bug Something isn't working
Milestone

Comments

@gino-m
Copy link
Collaborator

gino-m commented Nov 18, 2024

The UI appears to be removing the value, resulting in google/ground-platform#2099 and google/ground-platform#2098.

We may need to add a bool field to MultipleChoiceResponses to indicate the "other" option was selected; we can't rely on other_text being set since proto3 does not have a separate "unset" state for optional fields, so an empty string is considered the same as an unset field.

@kenstershiro @anandwana001 FYI

@gino-m gino-m added the type: bug Something isn't working label Nov 18, 2024
@gino-m gino-m changed the title [Data collection] "Other" multiple choice option not written to submission when no other text specified [Data collection] "Other" multiple choice option with no text not saved Nov 18, 2024
@kenstershiro kenstershiro added this to the GA release milestone Nov 19, 2024
@kenstershiro kenstershiro moved this to Todo in Ground Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants