Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tag and digest #391

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Allow tag and digest #391

merged 1 commit into from
Mar 5, 2019

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Mar 5, 2019

fixes #351

@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #391 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   51.63%   51.67%   +0.03%     
==========================================
  Files          77       77              
  Lines        3693     3696       +3     
==========================================
+ Hits         1907     1910       +3     
  Misses       1497     1497              
  Partials      289      289
Impacted Files Coverage Δ
pkg/name/digest.go 78.57% <100%> (+2.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abef031...a0f9a3d. Read the comment docs.

@jonjohnsonjr
Copy link
Collaborator

We might want to extend this to store an optional tag in the digest strcut so that NewDigest(str).String() == str but I think this is fine for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing image references with both tag and sha fails
3 participants