Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker API version negotiation happens too late #734

Closed
afbjorklund opened this issue Jun 27, 2020 · 1 comment · Fixed by #736
Closed

Docker API version negotiation happens too late #734

afbjorklund opened this issue Jun 27, 2020 · 1 comment · Fixed by #736

Comments

@afbjorklund
Copy link
Contributor

afbjorklund commented Jun 27, 2020

After the change in 4336215, it now happens after the open:

	if i.buffered {
		opener, err = i.bufferedOpener(i.ref)
	} else {
		opener, err = i.unbufferedOpener(i.ref)
	}
	if err != nil {
		return nil, err
	}

	i.client.NegotiateAPIVersion(context.Background())

pkg/v1/daemon/image.go

This means that it tries to run without first determining the highest version supported by the docker daemon:

Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40

So it (i.client.NegotiateAPIVersion) needs to happen before the i.client.ImageSave (in the opener)

We get this error in minikube.

@afbjorklund afbjorklund changed the title Docker API negotiation happens too late Docker API version negotiation happens too late Jun 27, 2020
@jonjohnsonjr
Copy link
Collaborator

Thanks -- sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants