-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-tarball Layers #1011
Comments
+1, We're using uncompressed, non-tarball blobs in |
+1 to removing tarball assumptions. Also +1 to moving We've also had some need for a |
I'm not in love with putting more logic in The best I've come up with would be We could have the |
v2! |
This issue is stale because it has been open for 90 days with no |
Static layer added in #1093 but we should try to clean up some of those assumptions still. |
Hi @jonjohnsonjr I'm running into a specific case of this in #1799 where I have a reader for an already-compressed layer (coming from an http request body) and want to upload it. A possible path forward is in #1800 to add another reader to the stream package. Hope you can take a look! This assumes the caller knows at development-time what these layers are going to include. Alternatives would be to use |
Ah, I was wondering if there is an issue for this (also see #1826 , which is not mine but I think is relevant). Also, much more importantly.. hi @imjasonh and @jonjohnsonjr 👋 I had to process an index off of a registry that had the buildkit-style attestation. Not getting into whether we like it or not; it is there, so I have to work with it. It looks like: {
"schemaVersion": 2,
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"config": {
"mediaType": "application/vnd.oci.image.config.v1+json",
"digest": "sha256:b7796d3d1d633a1abf8d69582d301387e65052ca848432a6631b01c9e6271871",
"size": 167
},
"layers": [
{
"mediaType": "application/vnd.in-toto+json",
"digest": "sha256:4377f521e1eae97005e106fe8d4aa37f2d49ed73c196d78f8297f395fca4be2d",
"size": 60722,
"annotations": {
"in-toto.io/predicate-type": "https://spdx.dev/Document"
}
}
]
} When I run It could be I am misusing |
I often want to upload some bytes to the registry, as is, and not have them be compressed. Or maybe I do want them to be compressed, but they're not a tarball. Sometimes I want to just set a different mediaType.
We don't have great support for that. We can add it, and it's not too hard, but we need to fix up some things:
validate
assumes layers are tarballs.mutate.Time
assumes layers are tarballs.mutate.Extract
assumes layers are tarballs.We probably want to add some support for setting the mediaType in
tarball
andstream
for layers.We also probably want to add support for disabling
gzip
altogether.We may want to automagically append
+gzip
to the mediaType when compressing it, in certain cases.Very relevant: #934
X-ref: we should never have put the layer logic in
tarball
: #413X-ref: we don't abstract away tarball with
Layer
: #487The text was updated successfully, but these errors were encountered: