Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API cleanups #63

Closed
ericchiang opened this issue Jul 31, 2019 · 2 comments · Fixed by #86
Closed

API cleanups #63

ericchiang opened this issue Jul 31, 2019 · 2 comments · Fixed by #86

Comments

@ericchiang
Copy link
Member

Looking at the exported API the package is a little cluttered. https://godoc.org/github.com/google/go-attestation/attest

Some thoughts for cleaning up the API, these are mostly just nits:
@ericchiang ericchiang changed the title Naming cleanups API cleanups Jul 31, 2019
@ericchiang
Copy link
Member Author

Other thoughts:

  • Can TPMInterface be private? We only need to determine how to load the AIK.
  • Convert map[int]PCR to []PCR? The PCR struct already contains an index, and it's redundant to hold that information as a map key as well.

@ericchiang
Copy link
Member Author

cc @twitchy-jsonp

@ericchiang ericchiang mentioned this issue Aug 20, 2019
Merged
@ericchiang ericchiang mentioned this issue Aug 28, 2019
Merged
@ericchiang ericchiang mentioned this issue Sep 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

attest: rename MintAIK and MintOptions to NewAIK and AIKConfig ericchiang/go-attestation
1 participant
@ericchiang