From 890a9dc95a4d508eedbafba7a6c14da8f8f57a35 Mon Sep 17 00:00:00 2001
From: Eng Zer Jun <engzerjun@gmail.com>
Date: Fri, 15 Nov 2024 12:09:36 +0800
Subject: [PATCH] ci: update `upload-artifact` and `download-artifact` actions
 to v4

v3 of `actions/upload-artifact` and `actions/download-artifact` will be
fully deprecated by 5 December 2024 [1][2].

[1]: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
[2]: https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
---
 .github/workflows/scorecard.yml                    | 2 +-
 .github/workflows/test.yaml                        | 8 ++++----
 axisregistry/.github/workflows/publish-release.yml | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml
index 637874e167a..340db0b54c1 100644
--- a/.github/workflows/scorecard.yml
+++ b/.github/workflows/scorecard.yml
@@ -59,7 +59,7 @@ jobs:
       # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
       # format to the repository Actions tab.
       - name: "Upload artifact"
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
+        uses: actions/upload-artifact@184d73b71b93c222403b2e7f1ffebe4508014249 # v4.4.3
         with:
           name: SARIF file
           path: results.sarif
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index f35d48971f7..f0a2f6a2f12 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -61,9 +61,9 @@ jobs:
 
       - name: Upload check results
         if: steps.check_files.outputs.files_exists == 'true'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: qa
+          name: qa-diffbrowsers-${{ matrix.os }}
           path: out/
 
   diffenator:
@@ -111,9 +111,9 @@ jobs:
 
       - name: Upload check results
         if: steps.check_files.outputs.files_exists == 'true'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: qa
+          name: qa-diffenator
           path: out/
 
   ftxvalidator:
diff --git a/axisregistry/.github/workflows/publish-release.yml b/axisregistry/.github/workflows/publish-release.yml
index e4070b724b3..8489c07db6d 100644
--- a/axisregistry/.github/workflows/publish-release.yml
+++ b/axisregistry/.github/workflows/publish-release.yml
@@ -50,7 +50,7 @@ jobs:
       - name: Build a binary wheel and a source tarball
         run: python3 -m build
       - name: Store the distribution packages
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: python-package-distributions
           path: dist/
@@ -69,7 +69,7 @@ jobs:
       id-token: write  # IMPORTANT: mandatory for trusted publishing
     steps:
       - name: Download all the dists
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: python-package-distributions
           path: dist/