Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run mypy in run_all_tests.sh #688

Closed
avital opened this issue Nov 27, 2020 · 2 comments · Fixed by #2594
Closed

Run mypy in run_all_tests.sh #688

avital opened this issue Nov 27, 2020 · 2 comments · Fixed by #2594
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. Status: pull requests welcome We agree with the direction proposed, feel free to give it a shot and file a pull request

Comments

@avital
Copy link
Contributor

avital commented Nov 27, 2020

Ideally we want both type checkers to work correctly at least for the library. Also mypy should offer a speedup

Originally posted by @jheek in #685 (comment)
@avital avital added Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. Status: pull requests welcome We agree with the direction proposed, feel free to give it a shot and file a pull request Type: maintenance labels Nov 27, 2020
@avital avital added this to the Core Team Productivity milestone Dec 1, 2020
@VIVelev VIVelev mentioned this issue Dec 11, 2020
Closed
@marcvanzee marcvanzee reopened this Apr 27, 2022
@marcvanzee marcvanzee removed this from the Core Team Productivity milestone Apr 28, 2022
@zaxtax zaxtax mentioned this issue Nov 8, 2022
Merged
4 tasks
@zaxtax
Copy link
Collaborator

zaxtax commented Nov 16, 2022

Can this be re-opened? Not all the mypy errors have been removed yet.

@marcvanzee marcvanzee reopened this Nov 16, 2022
@marcvanzee
Copy link
Collaborator

Sure, done!

@zaxtax zaxtax mentioned this issue Nov 29, 2022
Merged
4 tasks
@zaxtax zaxtax closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. Status: pull requests welcome We agree with the direction proposed, feel free to give it a shot and file a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Mypy type errors zaxtax/flax
3 participants
@zaxtax @avital @marcvanzee