This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Fix impl of memory directory's _renameSync. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Fix uses_dynamic_as_bottom error (dart-archive#63) Only pass boolean values to assert (dart-archive#64)
|
I think Travis is a flake? I saw a similar error locally which was transient. |
|
OK I genericized Be sure to squash my 100 commits! And I'd use the last message for the squashed commit message. |
|
Friendly ping. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/tools#620.
In the first commit of PR #63, I think analyzer should have warned me that the
_RenameOverwriteValidator<_DirectoryNode>callback was being passed a_Node, but it didn't! dart-lang/sdk#31410 I think. simplified dartpadThe alternative to this fix is type-annotating
_renameSyncwith a T, and declaringvalidateOverwriteExistingEntityto be a_RenameOverwriteValidator<T>.