Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended algorithm crashes the sample app #7930

Closed
mbalajee opened this issue Jun 18, 2024 · 3 comments · Fixed by #7969
Closed

Extended algorithm crashes the sample app #7930

mbalajee opened this issue Jun 18, 2024 · 3 comments · Fixed by #7969
Assignees
Labels
bug Something isn't working gltf Specific to glTF support

Comments

@mbalajee
Copy link
Contributor

mbalajee commented Jun 18, 2024

Describe the bug
Extended algorithm (from this PR) drastically slows down the rendering. When I opt in to the extended algorithm the model which was loading fine before (if I don't opt in) takes a very very long time to load & it eventually crashes

To Reproduce
Steps to reproduce the behavior:
Follow this step to opt in to extended asset loader

Expected behavior
There should be no difference in performance

Screenshots

Left - Opt in to extended algo | Without extended algo

filament_old_new.mov

Desktop (please complete the following information):

  • OS: Mac OS Sonoma
  • Backend: Metal

Additional context
Load a larger model to reproduce the degrade in performance & an eventual crash. I couldn't attach the model here since it is sensitive but any larger model (> 8K entities) will be impacted

@poweifeng
Copy link
Contributor

If you can point to a publicly available gltf with this issue, it'll help speed along the investigation. Also note that fixing any issues with the extended algo is not really prioritized at the moment since we really prefer to focus on exploring a better gltf loader overall.

@poweifeng poweifeng self-assigned this Jun 18, 2024
@poweifeng poweifeng added the gltf Specific to glTF support label Jun 18, 2024
@pixelflinger pixelflinger added the bug Something isn't working label Jun 18, 2024
@mbalajee
Copy link
Contributor Author

If you can point to a publicly available gltf with this issue, it'll help speed along the investigation. Also note that fixing any issues with the extended algo is not really prioritized at the moment since we really prefer to focus on exploring a better gltf loader overall.

I'll try to find some online but any glb with over 8 to 10K entities will be affected

@mbalajee
Copy link
Contributor Author

mbalajee commented Jul 8, 2024

@pixelflinger @poweifeng In the extended asset loader, gltf buffer is loaded for every primitive which is causing this issue. When loaded just once, the issue is fixed. Can we pls fix this as this is a blocker for our release ? I can put up a PR if you would like, lemme know

@pirlande-fw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gltf Specific to glTF support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants