Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsy/User-guide "skin" styles should be factored out and/or dropped in some cases #1655

Open
1 task done
chalin opened this issue Aug 10, 2023 · 0 comments
Open
1 task done
Labels
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 10, 2023

This issue is a part of:

Docsy has essential (including flow-related and spacing) styles, and other style changes that we might consider a Docsy/User-guide "skin" -- such as choices for colors, preferred table formating, etc:

// TODO: consider moving all of these theme-color definitions into the User
// Guide SCSS, or declare theme here, but namespaced:
$primary: #30638e !default;
$secondary: #ffa630 !default;
$success: #3772ff !default;
$info: #c0e0de !default;
$warning: #ed6a5a !default;
$danger: #ed6a5a !default;
$light: #d3f3ee !default; // TODO: consider using BS value
$dark: #403f4c !default; // TODO: consider using BS value

Another example is this button styling:

@if $enable-rounded {
.btn {
border-radius: 1rem;
&-lg {
border-radius: 2rem;
}
&-sm {
border-radius: 1rem;
}
}
}

Right now, it is a challenge for projects to opt out of these "skin" styles, since they need to address each style change individually.

@chalin chalin added this to the 23Q4 milestone Nov 8, 2023
@chalin chalin added design/style Front-end site design / styling cleanup/refactoring e0-minutes Effort < 60 min e1-hours p2-medium labels Nov 8, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Jan 11, 2024
@chalin chalin modified the milestones: 24Q1, 24Q2 Apr 2, 2024
@chalin chalin modified the milestones: 24Q2, 24Q3 Jul 2, 2024
@chalin chalin modified the milestones: 24Q3, 24Q4 Oct 3, 2024
@chalin chalin modified the milestones: 24Q4, 25Q1 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant