Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] blocks/section row-col hierarchy fix #1472

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Mar 8, 2023

Preview: https://deploy-preview-1472--docsydocs.netlify.app/about


Screenshots

Before

Notice the following problems (all of which are resolved by this PR):

  • White space between the end of the last block and the footer
  • Misformatting of bulleted lists
  • Excessive width
image

After

image

@chalin chalin force-pushed the chalin-im-blocks-section-2023-03-08 branch from 5593385 to b3b0930 Compare March 9, 2023 11:32
@chalin chalin requested review from deining, geriom and LisaFC March 9, 2023 13:06
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

layouts/shortcodes/blocks/section.html Show resolved Hide resolved
@chalin chalin merged commit e1b0f62 into google:main Mar 9, 2023
@chalin chalin deleted the chalin-im-blocks-section-2023-03-08 branch March 9, 2023 15:13
@LisaFC
Copy link
Collaborator

LisaFC commented Mar 9, 2023

Looks great, thanks Patrice!

@@ -2,7 +2,6 @@
title: About Docsy
linkTitle: About
menu: {main: {weight: 10}}
layout: docs
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisaFC et al.: prior to deleting line 5 above, there was a _print version of the about page, which pretty much looked like the non-print version. With line 5 gone, we've lot the _print version of the About page. Is that ok with you? Given that the two pages are identical AFAICT.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this is what the _print page looked like (excerpt), before this PR was merged:

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's a problem, given that the page was exactly the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants