-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BSv5] blocks/section row-col hierarchy fix #1472
[BSv5] blocks/section row-col hierarchy fix #1472
Conversation
6ba9105
to
5593385
Compare
5593385
to
b3b0930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Looks great, thanks Patrice! |
@@ -2,7 +2,6 @@ | |||
title: About Docsy | |||
linkTitle: About | |||
menu: {main: {weight: 10}} | |||
layout: docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LisaFC et al.: prior to deleting line 5 above, there was a _print
version of the about page, which pretty much looked like the non-print version. With line 5 gone, we've lot the _print
version of the About page. Is that ok with you? Given that the two pages are identical AFAICT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's a problem, given that the page was exactly the same.
blocks/section
stype
argument can be eithercontainer
(the default) orrow
.This is a BREAKING CHANGE. I've updated the docs and the CHANGELOG.
Preview: https://deploy-preview-1472--docsydocs.netlify.app/about
Screenshots
Before
Notice the following problems (all of which are resolved by this PR):
After