Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSP] dagger-android support #4044

Closed
dniHze opened this issue Aug 30, 2023 · 11 comments
Closed

[KSP] dagger-android support #4044

dniHze opened this issue Aug 30, 2023 · 11 comments

Comments

@dniHze
Copy link

dniHze commented Aug 30, 2023

Congrats on the release of the first KSP milestone!

Just a quick question. Are there any plans to make dagger-android compiler compatible with KSP moving forward?

Thank you!

@trevjonez
Copy link

At the very least the "implicit module inclusion" behavior that enables dagger-android to work should be made a general behavior before discontinuing full support for dagger-android

That would unlock quite a bit of innovation while giving those that want to avoid hilt a path forward.

@dniHze
Copy link
Author

dniHze commented Aug 31, 2023

TBH, I would be just happy getting a statement on it in the roadmap. We were thinking on replacing it with either vanilla Dagger or with Hilt. Not sure if it worth the effort for us to fork it and updating it support to updated compiler API.

@bcorso
Copy link

bcorso commented Aug 31, 2023

Yes, we will add KSP support for dagger-android now that Dagger and Hilt have been supported (see #2349 (comment)).

I don't anticipate this being a large amount of work, but it may still take a few weeks due to prioritization.

@nitinsethi86
Copy link

I tried mixing dagger-android usage with kapt and main dagger usage with ksp. It does not compile. Is it expected?

I see a compile time error with just usage of ksp for plain dagger.

@ContributesAndroidInjector was used, but dagger.android.processor.AndroidProcessor was not found on the processor path

@bcorso
Copy link

bcorso commented Sep 12, 2023

Yes, unfortunately you won't be able to mix kapt dagger-android and ksp dagger in the same Gradle module because the dagger processor requires access to files generated by the dagger-android compiler.

@Wrywulf
Copy link

Wrywulf commented Nov 9, 2023

@bcorso Out of curiosity, will this issue be the one tracking the development of KSP support for dagger-android, or is there another?

@bcorso
Copy link

bcorso commented Nov 9, 2023

Yep, this is the one.

@bcorso
Copy link

bcorso commented Nov 9, 2023

Also, fwiw, we do have someone actively working on this now. We'll update this ticket when it's ready.

@dniHze dniHze changed the title [Q][KSP] dagger-android support [KSP] dagger-android support Nov 9, 2023
@wanyingd1996
Copy link

wanyingd1996 commented Nov 14, 2023

Fixed with #4134

@trietbui85
Copy link

@wanyingd1996 Do you know when will the Dagger 2.48.2 with dagger-android support be released?

@bcorso
Copy link

bcorso commented Dec 1, 2023

@trietbui85 the Dagger 2.49 release is now out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants