Skip to content

Commit a6e65fa

Browse files
bcorsoDagger Team
authored andcommitted
Update Dagger's GitHub Actions to move the remaining emulator test to run in post-submit only.
The emulator tests have become more flaky recently and are also one of our slowest jobs in GitHub Actions. It should be fairly safe to move these to post-submit given our other non-emulator test coverage. This CL also updates the release script to use the large-runner. This should be negligible to the overall cost since releases are done so infrequently compared to presubmits. RELNOTES=N/A PiperOrigin-RevId: 587014286
1 parent b074037 commit a6e65fa

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -76,18 +76,6 @@ jobs:
7676
with:
7777
agp: '${{ matrix.agp }}'
7878
jdk: '${{ matrix.jdk }}'
79-
artifact-android-emulator-tests:
80-
name: 'Artifact Android emulator tests (API 30)'
81-
needs: bazel-build
82-
# It's recommended to run emulator tests on macOS
83-
# See https://github.com/marketplace/actions/android-emulator-runner
84-
runs-on: macos-latest
85-
steps:
86-
- uses: actions/checkout@v3
87-
- uses: ./.github/actions/artifact-android-emulator-tests
88-
timeout-minutes: 35 # TODO(b/287486065) investigate whether there is performance regression
89-
with:
90-
api-level: '30'
9179
artifact-android-emulator-legacy-api-tests:
9280
name: 'Artifact Android emulator tests (API ${{ matrix.api-level }})'
9381
# We only run this on master push (essentially a postsubmit) since these
@@ -99,7 +87,7 @@ jobs:
9987
runs-on: macos-latest
10088
strategy:
10189
matrix: # Run on 16 (PreL), 21 (L), and 26 (O).
102-
api-level: [16, 21, 26]
90+
api-level: [16, 21, 26, 30]
10391
steps:
10492
- uses: actions/checkout@v3
10593
- uses: ./.github/actions/artifact-android-emulator-tests

.github/workflows/release.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ jobs:
3939
bazel-test:
4040
name: 'Bazel tests'
4141
needs: validate-latest-dagger-version
42-
runs-on: ubuntu-latest
42+
runs-on:
43+
group: large-runner
44+
labels: ubuntu-22.04-16core
4345
steps:
4446
- uses: actions/checkout@v3
4547
- uses: ./.github/actions/bazel-test

0 commit comments

Comments
 (0)