Set application protocols on Android does not actually do the configuration

[voidzcy]

On Android platform (with FileDescriptorSocket), setting application protocols (via SSLParameters#setApplicationProtocols(...)) does not actually do the configuration. Looking at how it is implemented at

conscrypt/android/src/main/java/org/conscrypt/Platform.java

Lines 224 to 233 in 8e79804

	private static void setSSLParametersOnImpl(SSLParameters params, SSLParametersImpl impl)
	throws NoSuchMethodException, IllegalAccessException, InvocationTargetException {
	Method m_getEndpointIdentificationAlgorithm =
	params.getClass().getMethod("getEndpointIdentificationAlgorithm");
	impl.setEndpointIdentificationAlgorithm(
	(String) m_getEndpointIdentificationAlgorithm.invoke(params));
	Method m_getUseCipherSuitesOrder = params.getClass().getMethod("getUseCipherSuitesOrder");
	impl.setUseCipherSuitesOrder((boolean) m_getUseCipherSuitesOrder.invoke(params));
	}

application protocols are never put into SSLParametersImpl. This causes protocol configuration using SSLParameters API fail on Android.

[ejona86]

Note that this is especially a problem because SSLSocket.getApplicationProtocols() does not throw UnsupportedOperationException. That exception is the way for callers to determine if the particular SSLSocket supports the Java 9 ALPN API. So Conscrypt "claims" to support the Java 9 ALPN API but then doesn't actually support the setter.

[prbprbprb]

Good catch, thanks! It looks there are other inconsistencies around SNI between the three implementations (Android, Android Platform and OpenJDK).