Fix a bug in toSourceString by ensuring that grouping parens are added when needed

lukesandberg · copybara-github · commit 05dc664f7d1f · 2024-09-09T13:52:16.000-07:00
PiperOrigin-RevId: 658538818
diff --git a/java/src/com/google/template/soy/exprtree/DataAccessNode.java b/java/src/com/google/template/soy/exprtree/DataAccessNode.java
@@ -80,6 +80,9 @@ public final SourceLocation getAccessSourceLocation() {
 
   @Override
   public String toSourceString() {
+    if (SoyPrecedence.shouldGuard(this, getBaseExprChild())) {
+      return "(" + getBaseExprChild().toSourceString() + ")" + getSourceStringSuffix();
+    }
     return getBaseExprChild().toSourceString() + getSourceStringSuffix();
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,9 @@ public final SourceLocation getAccessSourceLocation() {`
`80`	`80`
`81`	`81`	`@Override`
`82`	`82`	`public String toSourceString() {`
	`83`	`+ if (SoyPrecedence.shouldGuard(this, getBaseExprChild())) {`
	`84`	`+ return "(" + getBaseExprChild().toSourceString() + ")" + getSourceStringSuffix();`
	`85`	`+ }`
`83`	`86`	`return getBaseExprChild().toSourceString() + getSourceStringSuffix();`
`84`	`87`	`}`
`85`	`88`	`}`