Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property reflection for Polymer computed properties and observers #3184

Closed
wants to merge 6 commits into from
Closed

Add property reflection for Polymer computed properties and observers #3184

wants to merge 6 commits into from

Commits on Jan 4, 2019

  1. Add property reflection for Polymer computed property and complex obs… 

    …erver strings
    @ChadKillingsworth
    ChadKillingsworth committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    ba830a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Add comments and address review issues.

    @ChadKillingsworth
    ChadKillingsworth committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    2e2bdae View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. Add the synthetic property sinks immediately after the class definiti… 

    …on to avoid unreachable code errors
    @ChadKillingsworth
    ChadKillingsworth committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    8416e48 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Insert property sinks after property type definitions

    @ChadKillingsworth
    ChadKillingsworth committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    55144a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Directly add property sinks rather than rely on the CheckSideEffects … 

    …pass to add them for us.

Prevents the compiler from assuming nullability on a property reference with no type annotation.
    @ChadKillingsworth
    ChadKillingsworth committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    f1b63f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. Prevent the property sink extern from being injected more than once

    @ChadKillingsworth
    ChadKillingsworth committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    ab1a00c View commit details
    Browse the repository at this point in the history