-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaStreamTrackProcessor Constructor #4109
Comments
According to the linked externs, the MediaStreamTrackProcessor is not a real class, but an interface that describes structure only. This doesn't seem to be correct according to mdn's docs (edit: and the spec too), which looks somewhat similar to what you've shared, except that the first arg should not be The linked externs conflict with yours, but both appear to be technically wrong. Perhaps make a PR to propose fixes to the linked file? Since commits come from inside of Google, it isn't clear who wrote or reviewed 70bd4d0 to ask about this discrepancy, maybe a maintainer can take a look? |
Would you mind sending a PR to update what correctly reflects the spec? |
It would be my first pull request :-D |
I'd be happy to work with you to get the PR ready to go. Sharing how you run the compiler would be great too - maybe a good post to discussions? |
That would be nice, maybe this week-end ? Should I clone the repository ? I opened a discussion ! |
I've been compiling a project using MediaStreamTrackProcessor instances for a long time, it was not included in the compiler so I was using a custom extern file with the following content :
The latest version returned a redeclared variable error, so I removed my extern file and got a new error : MediaStreamTrackProcessor is not constructor.
externs.zip//w3c_rtc.js:3645:9
I added two suppress annotations and re-included my externs file.
My project is compiling properly but I still get warnings about MediaStreamTrackProcessor not being a constructor.
The text was updated successfully, but these errors were encountered: