Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser error on "combining character" (U+0307) #3639

Open
skatsman opened this issue Jul 14, 2020 · 7 comments · May be fixed by #3647
Open

Parser error on "combining character" (U+0307) #3639

skatsman opened this issue Jul 14, 2020 · 7 comments · May be fixed by #3647
Labels
good first issue Relatively easy, but low priority bugs help wanted P3

Comments

@skatsman
Copy link

There seems to be an issue with parsing composite character sequences.

Composite character İ consist of the base character and combining character sequence (U+0049)(U+0307)
Using this character causing the compiler to fail with the parser error.

Example code

var bar = {
İ: "foo"
};

Compiler error

input0:2: ERROR - [JSC_PARSE_ERROR] Parse error. Character '̇' (U+0307) is not a valid identifier start char
  2| İ: "foo"
      ^

1 error(s), 0 warning(s)

Demo

Example
@rrdelaney
Copy link
Contributor

Is this a blocking error for you?

@skatsman
Copy link
Author

This prevents compiling one of the dependencies (lower-case) of graphql-tools which we use in our project

@rrdelaney rrdelaney added good first issue Relatively easy, but low priority bugs help wanted P3 labels Jul 15, 2020
ctjlewis added a commit to ctjlewis/closure-compiler that referenced this issue Jul 19, 2020
@ctjlewis
Added support for UnicodeCombiningMark, fixes google#3639.
5ad0744
This was referenced Jul 19, 2020
Closed
Closed
Open
Open
@thheller thheller mentioned this issue Apr 25, 2022
Closed
@sunng87 sunng87 mentioned this issue May 1, 2022
Closed
@thheller thheller mentioned this issue Jun 2, 2022
Closed
@jpduvet
Copy link

jpduvet commented Dec 20, 2022

Exactly the same issue with (U+3007) preventing compiling the dependency "fast-redact"

@thheller thheller mentioned this issue Jan 22, 2023
Closed
@thheller thheller mentioned this issue Feb 10, 2023
Closed
@icy0307
Copy link

icy0307 commented Mar 31, 2023

Exactly the same issue with (U+0941), which prevents compiling our source code.

@smogg
Copy link

smogg commented Jul 25, 2023 •
edited
Loading

Same problem with @tanstack/react-query-devtools.

Errors encountered while trying to parse file
  /node_modules/@tanstack/match-sorter-utils/build/lib/remove-accents.js
  {:line 131, :column 3, :message "Character '̆' (U+0306) is not a valid identifier start char"}

@brancusi
Copy link

Yes, getting this as well when using @tanstack/react-query-devtools

@SergejGleithmann
Copy link

SergejGleithmann commented May 16, 2024 •
edited
Loading

Hello, any idea, why the stopped working on this? Is there a way to bypass this issue? Im also having this with some leaflet react plugins (once in a css file and once in a png).
Edit: The CSS issue seems to be, because shadow-cljs does not support CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy, but low priority bugs help wanted P3
Projects
None yet
Milestone
No milestone
7 participants
@brancusi @smogg @skatsman @rrdelaney @icy0307 @jpduvet @SergejGleithmann