Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency sorting broken since release v20170626 #2661

Closed
AlastairTaft opened this issue Sep 24, 2017 · 1 comment
Closed

Dependency sorting broken since release v20170626 #2661

AlastairTaft opened this issue Sep 24, 2017 · 1 comment

Comments

@AlastairTaft
Copy link

AlastairTaft commented Sep 24, 2017

The following command works on version v20170521, however it falls over on version v20170626 through to the latest.

java -jar ./tools/closure-compiler/v20170521.jar --language_in=ECMASCRIPT6 --js_output_file=build/bundle.js --dependency_mode=STRICT --entry_point=src/index.js --js src/index.js --js src/orange.js --js src/apple.js

Falls over with

ERROR - required "module$src$apple" namespace never provided
import apple from './apple.js'

I'm using the ES6 import/export statements.

// index.js

import apple from './apple.js'

console.log(apple.getColour())
// apple.js


console.log('apple loaded')

import orange from './orange.js'

var apple = {}

apple['getColour'] = function(){
  return 'Green'
}

apple['getType'] = function(){
  return 'Granny Smith'
}

export default apple
// orange.js

console.log('Oranges loaded')

var test = {}

export default test
@ChadKillingsworth
Copy link
Collaborator

This is fixed by #2641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants