Skip to content

Commit c9f3d32

Browse files
nreid260copybara-github
nreid260
authored and
copybara-github
committed
Delete redundant information from POM files.
Since builds are now conducted with Bazel, and none of the JARs we release need any dependencies, all of the build configuration in the POM files can be deleted. All that's necessary is the project and artifact info. This change also moves/renames the POMs since they no longer need to be in the repo root. PiperOrigin-RevId: 333171273
1 parent 61e2812 commit c9f3d32

9 files changed

+209
-762
lines changed

‎BUILD.bazel

+5-5
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ sonatype_artifact_bundle(
3737
artifact_id = "closure-compiler",
3838
jar = ":compiler_shaded.jar",
3939
javadoc = ":compiler_lib.javadoc",
40-
pom = "pom-main-shaded.xml",
40+
pom = "maven/closure-compiler.pom.xml",
4141
sources = ":compiler_lib.sources",
4242
)
4343

@@ -46,27 +46,27 @@ sonatype_artifact_bundle(
4646
artifact_id = "closure-compiler-unshaded",
4747
jar = ":compiler_unshaded_deploy.jar",
4848
javadoc = ":compiler_lib.javadoc",
49-
pom = "pom-main-unshaded.xml",
49+
pom = "maven/closure-compiler-unshaded.pom.xml",
5050
sources = ":compiler_lib.sources",
5151
)
5252

5353
sonatype_artifact_bundle(
5454
name = "compiler_externs_bundle",
5555
artifact_id = "closure-compiler-externs",
5656
jar = ":externs",
57-
pom = "externs/pom.xml",
57+
pom = "maven/closure-compiler-externs.pom.xml",
5858
)
5959

6060
sonatype_artifact_bundle(
6161
name = "compiler_main_bundle",
6262
artifact_id = "closure-compiler-main",
63-
pom = "pom-main.xml",
63+
pom = "maven/closure-compiler-main.pom.xml",
6464
)
6565

6666
sonatype_artifact_bundle(
6767
name = "compiler_parent_bundle",
6868
artifact_id = "closure-compiler-parent",
69-
pom = "pom.xml",
69+
pom = "maven/closure-compiler-parent.pom.xml",
7070
)
7171

7272
jar_jar(

‎externs/pom.xml renamed to ‎maven/closure-compiler-externs.pom.xml

+1-38
Original file line numberDiff line numberDiff line change
@@ -26,47 +26,10 @@
2626
<name>Closure Compiler Externs</name>
2727
<version>1.0-SNAPSHOT</version>
2828

29-
<properties>
30-
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
31-
<project.build.outputEncoding>UTF-8</project.build.outputEncoding>
32-
</properties>
33-
3429
<parent>
3530
<groupId>com.google.javascript</groupId>
3631
<artifactId>closure-compiler-parent</artifactId>
3732
<version>1.0-SNAPSHOT</version>
38-
<relativePath>../pom.xml</relativePath>
33+
<relativePath>closure-compiler-parent.pom.xml</relativePath>
3934
</parent>
40-
41-
<build>
42-
<defaultGoal>install</defaultGoal>
43-
<plugins>
44-
<plugin>
45-
<artifactId>maven-antrun-plugin</artifactId>
46-
<executions>
47-
<execution>
48-
<phase>generate-sources</phase>
49-
<configuration>
50-
<tasks>
51-
<zip destfile="../target/classes/externs.zip" basedir="." includes="**/*.js"/>
52-
<zip destfile="target/classes/externs.zip" basedir="." includes="**/*.js"/>
53-
</tasks>
54-
</configuration>
55-
<goals>
56-
<goal>run</goal>
57-
</goals>
58-
</execution>
59-
</executions>
60-
</plugin>
61-
<plugin>
62-
<groupId>org.apache.maven.plugins</groupId>
63-
<artifactId>maven-resources-plugin</artifactId>
64-
</plugin>
65-
</plugins>
66-
<resources>
67-
<resource>
68-
<directory>target/generated-resources//</directory>
69-
</resource>
70-
</resources>
71-
</build>
7235
</project>

‎maven/closure-compiler-main.pom.xml

+51
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
<!--
2+
Copyright 2009 Google Inc.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
-->
16+
<project xmlns="http://maven.apache.org/POM/4.0.0"
17+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
18+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
19+
>
20+
<modelVersion>4.0.0</modelVersion>
21+
22+
<groupId>com.google.javascript</groupId>
23+
<artifactId>closure-compiler-main</artifactId>
24+
<packaging>pom</packaging>
25+
26+
<name>Closure Compiler Main</name>
27+
<version>1.0-SNAPSHOT</version>
28+
29+
<url>https://developers.google.com/closure/compiler/</url>
30+
<description>
31+
Closure Compiler is a JavaScript optimizing compiler. It parses your
32+
JavaScript, analyzes it, removes dead code and rewrites and minimizes
33+
what's left. It also checks syntax, variable references, and types, and
34+
warns about common JavaScript pitfalls. It is used in many of Google's
35+
JavaScript apps, including Gmail, Google Web Search, Google Maps, and
36+
Google Docs.
37+
</description>
38+
<inceptionYear>2009</inceptionYear>
39+
40+
<parent>
41+
<groupId>com.google.javascript</groupId>
42+
<artifactId>closure-compiler-parent</artifactId>
43+
<version>1.0-SNAPSHOT</version>
44+
<relativePath>closure-compiler-parent.pom.xml</relativePath>
45+
</parent>
46+
47+
<modules>
48+
<module>closure-compiler.pom.xml</module>
49+
<module>closure-compiler-unshaded.pom.xml</module>
50+
</modules>
51+
</project>

‎maven/closure-compiler-parent.pom.xml

+105
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
1+
<!--
2+
Copyright 2009 Google Inc.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
-->
16+
<project xmlns="http://maven.apache.org/POM/4.0.0"
17+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
18+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
19+
>
20+
<modelVersion>4.0.0</modelVersion>
21+
<groupId>com.google.javascript</groupId>
22+
<artifactId>closure-compiler-parent</artifactId>
23+
<packaging>pom</packaging>
24+
25+
<name>Closure Compiler Parent</name>
26+
<version>1.0-SNAPSHOT</version>
27+
28+
<url>https://github.com/google/closure-compiler/</url>
29+
<description>
30+
Closure Compiler is a JavaScript optimizing compiler. It parses your
31+
JavaScript, analyzes it, removes dead code and rewrites and minimizes
32+
what's left. It also checks syntax, variable references, and types, and
33+
warns about common JavaScript pitfalls. It is used in many of Google's
34+
JavaScript apps, including Gmail, Google Web Search, Google Maps, and
35+
Google Docs.
36+
</description>
37+
<inceptionYear>2009</inceptionYear>
38+
39+
<prerequisites>
40+
<maven>2.2.1</maven>
41+
</prerequisites>
42+
43+
<scm>
44+
<connection>
45+
scm:git:https://github.com/google/closure-compiler.git
46+
</connection>
47+
<developerConnection>
48+
scm:git:[email protected]:google/closure-compiler.git
49+
</developerConnection>
50+
<url>
51+
https://github.com/google/closure-compiler
52+
</url>
53+
</scm>
54+
55+
<issueManagement>
56+
<system>code.google.com</system>
57+
<url>https://github.com/google/closure-compiler/issues</url>
58+
</issueManagement>
59+
60+
<organization>
61+
<name>Google</name>
62+
<url>http://www.google.com</url>
63+
</organization>
64+
65+
<developers>
66+
<developer>
67+
<id>closure-compiler-authors</id>
68+
<name>Closure Compiler Authors</name>
69+
<email>[email protected] </email>
70+
</developer>
71+
</developers>
72+
73+
<licenses>
74+
<license>
75+
<name>The Apache Software License, Version 2.0</name>
76+
<url>http://www.apache.org/licenses/LICENSE-2.0.html</url>
77+
<distribution>repo</distribution>
78+
</license>
79+
</licenses>
80+
81+
<!--
82+
TODO: test deployment without this parent.
83+
http://central.sonatype.org/pages/apache-maven.html#deprecated-oss-parent says
84+
85+
> In the past all the plugin configuration and other setup was
86+
> managed by a Maven parent POM with the latest coordinates of
87+
> org.sonatype.oss:oss-parent:9. This project leaked SCM, URL and
88+
> other details and its usage is discouraged. Maintenance of the
89+
> project has stopped and it no longer works with latest tooling
90+
> such as Maven versions or Java versions.
91+
92+
It may be sufficient to include a <distributionManagement> per
93+
http://central.sonatype.org/pages/apache-maven.html#distribution-management-and-authentication
94+
-->
95+
<parent>
96+
<groupId>org.sonatype.oss</groupId>
97+
<artifactId>oss-parent</artifactId>
98+
<version>9</version>
99+
</parent>
100+
101+
<modules>
102+
<module>closure-compiler-externs.pom.xml</module>
103+
<module>closure-compiler-main.pom.xml</module>
104+
</modules>
105+
</project>

‎pom-main-unshaded.xml renamed to ‎maven/closure-compiler-unshaded.pom.xml

+1-16
Original file line numberDiff line numberDiff line change
@@ -41,21 +41,6 @@
4141
<groupId>com.google.javascript</groupId>
4242
<artifactId>closure-compiler-main</artifactId>
4343
<version>1.0-SNAPSHOT</version>
44-
<relativePath>pom-main.xml</relativePath>
44+
<relativePath>closure-compiler-main.pom.xml</relativePath>
4545
</parent>
46-
47-
<build>
48-
<plugins>
49-
<plugin>
50-
<groupId>org.apache.maven.plugins</groupId>
51-
<artifactId>maven-jar-plugin</artifactId>
52-
<configuration>
53-
<archive>
54-
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
55-
</archive>
56-
</configuration>
57-
</plugin>
58-
</plugins>
59-
</build>
60-
6146
</project>

‎maven/closure-compiler.pom.xml

+46
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
<!--
2+
Copyright 2009 Google Inc.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
-->
16+
<project xmlns="http://maven.apache.org/POM/4.0.0"
17+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
18+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
19+
>
20+
<modelVersion>4.0.0</modelVersion>
21+
22+
<groupId>com.google.javascript</groupId>
23+
<artifactId>closure-compiler</artifactId>
24+
<packaging>jar</packaging>
25+
26+
<name>Closure Compiler</name>
27+
<version>1.0-SNAPSHOT</version>
28+
29+
<url>https://developers.google.com/closure/compiler/</url>
30+
<description>
31+
Closure Compiler is a JavaScript optimizing compiler. It parses your
32+
JavaScript, analyzes it, removes dead code and rewrites and minimizes
33+
what's left. It also checks syntax, variable references, and types, and
34+
warns about common JavaScript pitfalls. It is used in many of Google's
35+
JavaScript apps, including Gmail, Google Web Search, Google Maps, and
36+
Google Docs.
37+
</description>
38+
<inceptionYear>2009</inceptionYear>
39+
40+
<parent>
41+
<groupId>com.google.javascript</groupId>
42+
<artifactId>closure-compiler-main</artifactId>
43+
<version>1.0-SNAPSHOT</version>
44+
<relativePath>closure-compiler-main.pom.xml</relativePath>
45+
</parent>
46+
</project>

0 commit comments

Comments
 (0)