Skip to content

Commit 3734b26

Browse files
tbreisacherblickly
tbreisacher
authored andcommitted
Remove the arguments usage check. Users never really liked it, and the primary motivation for creating it is a non-issue now that 6a40212 is submitted.
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=116147157
1 parent a5166e4 commit 3734b26

File tree

5 files changed

+0
-143
lines changed

5 files changed

+0
-143
lines changed

src/com/google/javascript/jscomp/DefaultPassConfig.java

-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import com.google.javascript.jscomp.ExtractPrototypeMemberDeclarations.Pattern;
3232
import com.google.javascript.jscomp.NodeTraversal.Callback;
3333
import com.google.javascript.jscomp.PassFactory.HotSwapPassFactory;
34-
import com.google.javascript.jscomp.lint.CheckArguments;
3534
import com.google.javascript.jscomp.lint.CheckDuplicateCase;
3635
import com.google.javascript.jscomp.lint.CheckEmptyStatements;
3736
import com.google.javascript.jscomp.lint.CheckEnums;
@@ -1558,7 +1557,6 @@ protected HotSwapCompilerPass create(AbstractCompiler compiler) {
15581557
@Override
15591558
protected HotSwapCompilerPass create(AbstractCompiler compiler) {
15601559
ImmutableList.Builder<Callback> callbacks = ImmutableList.<Callback>builder()
1561-
.add(new CheckArguments(compiler))
15621560
.add(new CheckEmptyStatements(compiler))
15631561
.add(new CheckEnums(compiler))
15641562
.add(new CheckInterfaces(compiler))

src/com/google/javascript/jscomp/DiagnosticGroups.java

-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.google.common.base.Preconditions;
2121
import com.google.common.collect.ImmutableMap;
2222
import com.google.common.collect.ImmutableSet;
23-
import com.google.javascript.jscomp.lint.CheckArguments;
2423
import com.google.javascript.jscomp.lint.CheckDuplicateCase;
2524
import com.google.javascript.jscomp.lint.CheckEmptyStatements;
2625
import com.google.javascript.jscomp.lint.CheckEnums;
@@ -468,7 +467,6 @@ public DiagnosticGroup forName(String name) {
468467
// provide optional suggestions.
469468
public static final DiagnosticGroup LINT_CHECKS =
470469
DiagnosticGroups.registerGroup("lintChecks", // undocumented
471-
CheckArguments.BAD_ARGUMENTS_USAGE,
472470
CheckEmptyStatements.USELESS_EMPTY_STATEMENT,
473471
CheckEnums.COMPUTED_PROP_NAME_IN_ENUM,
474472
CheckEnums.DUPLICATE_ENUM_VALUE,

src/com/google/javascript/jscomp/LintPassConfig.java

-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import com.google.common.collect.ImmutableList;
1919
import com.google.javascript.jscomp.NodeTraversal.Callback;
20-
import com.google.javascript.jscomp.lint.CheckArguments;
2120
import com.google.javascript.jscomp.lint.CheckDuplicateCase;
2221
import com.google.javascript.jscomp.lint.CheckEmptyStatements;
2322
import com.google.javascript.jscomp.lint.CheckEnums;
@@ -107,7 +106,6 @@ protected CompilerPass create(AbstractCompiler compiler) {
107106
return new CombinedCompilerPass(
108107
compiler,
109108
ImmutableList.<Callback>of(
110-
new CheckArguments(compiler),
111109
new CheckDuplicateCase(compiler),
112110
new CheckEmptyStatements(compiler),
113111
new CheckEnums(compiler),

src/com/google/javascript/jscomp/lint/CheckArguments.java

-86
This file was deleted.

test/com/google/javascript/jscomp/lint/CheckArgumentsTest.java

-51
This file was deleted.

0 commit comments

Comments
 (0)