Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect instructions when running clasp logs --setup #804

Open
leeyspaul opened this issue Aug 15, 2020 · 4 comments
Open

Incorrect instructions when running clasp logs --setup #804

leeyspaul opened this issue Aug 15, 2020 · 4 comments

Comments

@leeyspaul
Copy link

(Note: Non-breaking issues are likely not to be prioritized. Please consider a PR in addition to your issue)

Expected Behavior

When running clasp logs --setup I'd expect including project-id into the input to be correct.

$ clasp logs --setup
Open this link: 
<scriptUrl>

Go to *Resource > Cloud Platform Project...* and copy your projectId
(including "project-id-")

? What is your GCP projectId? project-id-my-app

Actual Behavior

$ clasp logs --setup
Open this link: 
<scriptUrl>

Go to *Resource > Cloud Platform Project...* and copy your projectId
(including "project-id-")

? What is your GCP projectId? project-id-my-app

The projectId "project-id-my-app" looks incorrect.
Did you provide the correct projectID?

Line: https://github.com/google/clasp/blob/master/src/messages.ts#L128

Steps to Reproduce the Problem

  1. Run clasp logs --setup and input the "project-id"

Specifications

  • Node version (node -v): v10.10.0
  • Version (clasp -v): 2.3.0
  • OS (Mac/Linux/Windows): Mac
@PopGoesTheWza
Copy link
Collaborator

Is this strictly a documentation issue? Can anyone volunteer for a PR?

@noahmercado
Copy link

Is clasp expecting the project-id or the project number? The Scripts editor allows us to set the underlying GCP project via the project number, but this prompt is asking for the project-id. I'm happy to take this PR (as well as #813 ) if someone can help me understand the intended functionality

@branchtools
Copy link

why isn't this fixed yet? I want to be able to run logs and the proiject ID issue is still broken four years later?

@ChuckJonas
Copy link

clasp feels so broken... Trying to get it setup and the docs/cli instructions are just all over the place. Please fix this stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants