-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushing V8 code into non-V8 project #765
Comments
Could you wait #778 merging then return to this again? |
@bjohas are you pushing plain .js or .ts? If its .js then catching the error would be nice to have. |
Plain .js, i.e., trying to push "V8-plain-js" into a non-V8 project. I'll look out for the PR merge and then try again. |
#778 have a cleaner error handling architecture but there is probably not yet a user friendly catch for this case |
OK, sure - I'll test again once #778 has been merged. |
Thanks for working on |
Can you test with the #791 unofficial release? npm uninstall -g @google/clasp && npm install -g forked-clasp
clasp --version
# should be 2.4.0 or more |
Thank you - will do and report back! |
@bjohas what is the status for this issue? |
Should be fixed in https://github.com/google/clasp/releases/tag/v2.3.1 |
Thank you so much - I'm sorry I didn't get round to testing it, as the old code had gone away. I'd be happy for this to be closed. If I come across the error again, I can always come back to this? |
When pushing V8 code into non-V8 project, the push fails. Howeer, the error message "Error: Syntax error: Missing ; before statement. ", while obviously true, didn't immediately make me realise that this is with V8/non-V8 code.
Expected Behavior
A warning message would be helpful, but may not be possible.
Specifications
2.3.0
The text was updated successfully, but these errors were encountered: