Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing V8 code into non-V8 project #765

Open
bjohas opened this issue Apr 28, 2020 · 11 comments
Open

Pushing V8 code into non-V8 project #765

bjohas opened this issue Apr 28, 2020 · 11 comments

Comments

@bjohas
Copy link

bjohas commented Apr 28, 2020

When pushing V8 code into non-V8 project, the push fails. Howeer, the error message "Error: Syntax error: Missing ; before statement. ", while obviously true, didn't immediately make me realise that this is with V8/non-V8 code.

Expected Behavior

A warning message would be helpful, but may not be possible.

Specifications

2.3.0

@oshliaer
Copy link
Contributor

Could you wait #778 merging then return to this again?

@PopGoesTheWza
Copy link
Collaborator

@bjohas are you pushing plain .js or .ts?

If its .js then catching the error would be nice to have.

@bjohas
Copy link
Author

bjohas commented May 27, 2020

Plain .js, i.e., trying to push "V8-plain-js" into a non-V8 project. I'll look out for the PR merge and then try again.

@PopGoesTheWza
Copy link
Collaborator

#778 have a cleaner error handling architecture but there is probably not yet a user friendly catch for this case

@bjohas
Copy link
Author

bjohas commented May 27, 2020

OK, sure - I'll test again once #778 has been merged.

@bjohas
Copy link
Author

bjohas commented May 27, 2020

Thanks for working on clasp!

@PopGoesTheWza
Copy link
Collaborator

Can you test with the #791 unofficial release?

npm uninstall -g @google/clasp && npm install -g forked-clasp
clasp --version
# should be 2.4.0 or more

@bjohas
Copy link
Author

bjohas commented Jul 15, 2020

Thank you - will do and report back!

@PopGoesTheWza PopGoesTheWza added the forked-clasp fixed in forked-clasp label Mar 19, 2021
@PopGoesTheWza
Copy link
Collaborator

@bjohas what is the status for this issue?

@PopGoesTheWza PopGoesTheWza removed the forked-clasp fixed in forked-clasp label May 12, 2021
@PopGoesTheWza
Copy link
Collaborator

@bjohas
Copy link
Author

bjohas commented May 14, 2021

Thank you so much - I'm sorry I didn't get round to testing it, as the old code had gone away. I'd be happy for this to be closed. If I come across the error again, I can always come back to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants