Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(node:17396) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated #657

Open
JeanRemiDelteil opened this issue Jul 2, 2019 · 7 comments
Labels
in next release fixed in master branch, pending npm release

Comments

@JeanRemiDelteil
Copy link
Contributor

Expected Behavior

No deprecation warrning when using clasp push

Actual Behavior

when using clasp push we have a deprecation warrning on Node v12.3.1

(node:17396) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated

Steps to Reproduce the Problem

  1. update Node to the current version (12.x)
  2. use clasp push in a project

Specifications

  • Node version (node -v): v12.3.1
  • Version (clasp -v): 2.1.0
  • OS (Mac/Linux/Windows): Windows10
@PopGoesTheWza
Copy link
Collaborator

@JeanRemiDelteil just to be certain, this issue occurs with the latest npm? Have you tried using a local build from the current master of this repository?

@PopGoesTheWza
Copy link
Collaborator

PopGoesTheWza commented Jul 3, 2019

For reference: DEP0066: OutgoingMessage.prototype._headers, OutgoingMessage.prototype._headerNames

@JeanRemiDelteil @grant I was able to reproduce this issue on Mac OS, using Node 12.3.1 and npm's [email protected]
I then used a local build from this repository and the deprecation warning no longer occured.

This issue is likely to be closed with next release of clasp.

@JeanRemiDelteil
Copy link
Contributor Author

Great !

@grant
Copy link
Contributor

grant commented Jul 3, 2019

Note: I've published @google/[email protected]

@koconnor3
Copy link

any updates on this? I'm still seeing "(node:...) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated"

@PopGoesTheWza
Copy link
Collaborator

@koconnor3 what version of nodejs and clasp are you using?

@koconnor3
Copy link

@koconnor3 what version of nodejs and clasp are you using?

my bad, looks like I had only updated clasp on my other machine 🤦‍♂️

@PopGoesTheWza PopGoesTheWza added the in next release fixed in master branch, pending npm release label Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in next release fixed in master branch, pending npm release
Projects
None yet
Development

No branches or pull requests

4 participants