Missing clasp support for Drive Activity API

[tehhowch]

Expected Behavior

Drive Activity API can be enabled via clasp apis enable driveactivity, and the project can continue to be worked with. This is expected because the API can be enabled via the web UI:

Actual Behavior

appsscript.json receives a null entry:

Any clasp operation using/modifying the manifest then fails (e.g. push, additional apis ____), since the null value cannot be consumed:

(Note that the enable/disable goes through to the GCP, but the local manifest file is not updated)

Steps to Reproduce the Problem

1. clasp create --standalone
2. clasp apis enable driveactivity
   

Specifications

• Node version (node -v): 8.11.2
• Version (clasp -v): 2.0.1
• OS (Mac/Linux/Windows): Win 10

[erickoledadevrel]

Thanks for the detailed issue report. There seem to be two problems here:

1. The new advanced service DriveActivity hasn't been added to the PUBLIC_ADVANCED_SERVICES constant. Unfortunately there is no way to programmatically retrieve this information at the moment and it must be manually kept in sync with the Apps Script UI.
2. When adding the advanced service to the manifest there is currently no error handling for when the enabled API isn't in the PUBLIC_ADVANCED_SERVICES enum. As seen here, if not found the null is added to the manifest.

Fixing the first problem should be a simple PR to add the details to the constant. Fixing the second problem involves checking for null, and if so skipping the manifest modification and logging a warning.

@grant - Does that sound reasonable?

[erickoledadevrel]

Ping @grant.

[grant]

Sounds fine @erickoledadevrel.
This is one of the features that tries to help the Apps Script developer experience, but is really an issue with the lack of a feature with the Apps Script API.

We should simply fail gracefully at least.