Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clasp status ignores .claspignore #439

Closed
paxperscientiam opened this issue Dec 7, 2018 · 3 comments
Closed

clasp status ignores .claspignore #439

paxperscientiam opened this issue Dec 7, 2018 · 3 comments

Comments

@paxperscientiam
Copy link

Expected Behavior

Lists files to be pushed.

Actual Behavior

Lists files to be pushed AND ignored files.

Steps to Reproduce the Problem

  1. Add patterns to .claspignore
  2. Execute clasp status
  3. See incorrect results.

Specifications

  • Node version (node -v): v9.11.2
  • Version (clasp -v): 1.6.3
  • OS (Mac/Linux/Windows): 10.14.1
@johnnyasantoss
Copy link
Contributor

I'm seeing the same behavior on 1.7.0

@johnnyasantoss
Copy link
Contributor

I've found why this happens.. to me I'm using a .claspignore file with unix path separator / and I'm using Windows to develop my application. When clasp checks the ignored files' path it doesn't normalize the paths which makes them different dist\build.js (what the os/node returns when listing the files) !== dist/build.js (what is on my ignore file).

I'm sending a PR which fixes this, but right now you can just change the path separators and it should work.

@johnnyasantoss
Copy link
Contributor

@grant Can this be pushed to a new version?
This also fixes clasp push for files that shouldn't be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants