Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadtimezone and n_sec impl is slow in starrocks #212

Open
aaawuanjun opened this issue Jan 18, 2022 · 4 comments
Open

loadtimezone and n_sec impl is slow in starrocks #212

aaawuanjun opened this issue Jan 18, 2022 · 4 comments

Comments

@aaawuanjun
Copy link

other olap use cctz, it occure 2 function inside cctz
n_sec and loadTimeZone
it calls too much time, so kernel goes the spin_lock_slowpath

image

@devbww
Copy link
Contributor

devbww commented Jan 18, 2022

I'm afraid your report lacks enough context so as to render it unactionable.

If you believe any CCTZ functions are doing unnecessary work, or have ideas about optimizations, please submit your detailed thoughts. Thanks.

@aaawuanjun
Copy link
Author

First, change normal lock to readwrite lock in LoadTimeZone method

@aaawuanjun
Copy link
Author

about read write lock, see pull #214

before modify, lock has race condition
online information:
image

test env information:
image

after this, lock's hot will decrease
test env information:
image

brpc's lock info inside LoadTimeZone will down

@aaawuanjun
Copy link
Author

what's the period of new version comes out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants