Skip to content

Commit 0b9149c

Browse files
author
Dan Palmer
committed
Prepare for release 1.15.4.
1 parent f1d79e6 commit 0b9149c

File tree

5 files changed

+3
-28
lines changed

5 files changed

+3
-28
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,4 @@ https://developer.android.com/studio/command-line/bundletool
4646

4747
## Releases
4848

49-
Latest release: [1.15.3](https://github.com/google/bundletool/releases)
49+
Latest release: [1.15.4](https://github.com/google/bundletool/releases)

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
release_version = 1.15.3
1+
release_version = 1.15.4

src/main/java/com/android/tools/build/bundletool/model/ManifestEditor.java

-6
Original file line numberDiff line numberDiff line change
@@ -306,12 +306,6 @@ public ManifestEditor setSplitsRequired(boolean value) {
306306
setMetadataValue(
307307
META_DATA_KEY_SPLITS_REQUIRED,
308308
createAndroidAttribute("value", VALUE_RESOURCE_ID).setValueAsBoolean(value));
309-
310-
manifestElement
311-
.getOrCreateAndroidAttribute(
312-
IS_SPLIT_REQUIRED_ATTRIBUTE_NAME, IS_SPLIT_REQUIRED_RESOURCE_ID)
313-
.setValueAsBoolean(value);
314-
315309
return setApplcationAttributeBoolean(
316310
IS_SPLIT_REQUIRED_ATTRIBUTE_NAME, IS_SPLIT_REQUIRED_RESOURCE_ID, value);
317311
}

src/main/java/com/android/tools/build/bundletool/model/version/BundleToolVersion.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*/
2727
public final class BundleToolVersion {
2828

29-
private static final String CURRENT_VERSION = "1.15.3";
29+
private static final String CURRENT_VERSION = "1.15.4";
3030

3131

3232
/** Returns the version of BundleTool being run. */

src/test/java/com/android/tools/build/bundletool/model/ManifestEditorTest.java

-19
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@
8383
import com.android.tools.build.bundletool.model.manifestelements.Provider;
8484
import com.android.tools.build.bundletool.model.manifestelements.Receiver;
8585
import com.android.tools.build.bundletool.model.utils.xmlproto.XmlProtoAttribute;
86-
import com.android.tools.build.bundletool.model.utils.xmlproto.XmlProtoAttributeBuilder;
8786
import com.android.tools.build.bundletool.model.utils.xmlproto.XmlProtoElement;
8887
import com.android.tools.build.bundletool.model.utils.xmlproto.XmlProtoElementBuilder;
8988
import com.google.common.collect.ImmutableList;
@@ -474,12 +473,6 @@ public void setSplitsRequired() throws Exception {
474473
IS_SPLIT_REQUIRED_ATTRIBUTE_NAME,
475474
IS_SPLIT_REQUIRED_RESOURCE_ID,
476475
true));
477-
assertThat(editedManifest.getManifestElement().getAttributes())
478-
.containsExactly(
479-
XmlProtoAttributeBuilder.createAndroidAttribute(
480-
IS_SPLIT_REQUIRED_ATTRIBUTE_NAME, IS_SPLIT_REQUIRED_RESOURCE_ID)
481-
.setValueAsBoolean(true)
482-
.build());
483476
}
484477

485478
@Test
@@ -504,12 +497,6 @@ public void setSplitsRequired_idempotent() throws Exception {
504497
IS_SPLIT_REQUIRED_ATTRIBUTE_NAME,
505498
IS_SPLIT_REQUIRED_RESOURCE_ID,
506499
true));
507-
assertThat(editedManifest.getManifestElement().getAttributes())
508-
.containsExactly(
509-
XmlProtoAttributeBuilder.createAndroidAttribute(
510-
IS_SPLIT_REQUIRED_ATTRIBUTE_NAME, IS_SPLIT_REQUIRED_RESOURCE_ID)
511-
.setValueAsBoolean(true)
512-
.build());
513500
}
514501

515502
@Test
@@ -534,12 +521,6 @@ public void setSplitsRequired_lastInvocationWins() throws Exception {
534521
IS_SPLIT_REQUIRED_ATTRIBUTE_NAME,
535522
IS_SPLIT_REQUIRED_RESOURCE_ID,
536523
false));
537-
assertThat(editedManifest.getManifestElement().getAttributes())
538-
.containsExactly(
539-
XmlProtoAttributeBuilder.createAndroidAttribute(
540-
IS_SPLIT_REQUIRED_ATTRIBUTE_NAME, IS_SPLIT_REQUIRED_RESOURCE_ID)
541-
.setValueAsBoolean(false)
542-
.build());
543524
}
544525

545526
@Test

0 commit comments

Comments
 (0)