From 33f292db24e7a57318dcc2cadc971b0fb4281c0b Mon Sep 17 00:00:00 2001 From: Maribeth Bottorff Date: Wed, 16 Aug 2023 21:28:20 -0700 Subject: [PATCH 1/3] chore: update PR template and add info for new contribs --- .github/PULL_REQUEST_TEMPLATE.md | 5 +-- .../workflows/welcome_new_contributors.yml | 37 +++++++++++++++++++ 2 files changed, 38 insertions(+), 4 deletions(-) create mode 100644 .github/workflows/welcome_new_contributors.yml diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0cf78b1cebc..0eb45d1ef11 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,10 +7,7 @@ -- [ ] I branched from develop -- [ ] My pull request is against develop -- [ ] My code follows the [style guide](https://developers.google.com/blockly/guides/modify/web/style-guide) -- [ ] I ran `npm run format` and `npm run lint` +- [ ] I [validated my changes](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change) ## The details ### Resolves diff --git a/.github/workflows/welcome_new_contributors.yml b/.github/workflows/welcome_new_contributors.yml new file mode 100644 index 00000000000..2f5a3a96cc0 --- /dev/null +++ b/.github/workflows/welcome_new_contributors.yml @@ -0,0 +1,37 @@ +on: + pull_request_target: + types: + - opened +name: Welcome new contributors +jobs: + welcome: + runs-on: ubuntu-latest + permissions: + pull-requests: write + steps: + - uses: actions/first-interaction@v1 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} + pr-message: > + Welcome! It looks like this is your first pull request in blockly, + so here are a couple of tips: + + - You can find tips about contributing to Blockly and how to + validate your changes on our + [developer site](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change). + + - All contributors must sign the Google Contributor License + Agreement (CLA). If the google-cla bot leaves a comment on this + PR, make sure you follow the instructions. + + - We use [conventional commits](https://www.conventionalcommits.org/) + to make versioning the package easier. Make sure your commit + message is in the [proper format](https://developers.google.com/blockly/guides/contribute/get-started/commits) + or [learn how to fix it](https://developers.google.com/blockly/guides/contribute/get-started/commits#fixing_non-conventional_commits). + + - If any of the other checks on this PR fail, you can click on + them to learn why. It might be that your change caused a test + failure, or that you need to double-check the + [style guide](https://developers.google.com/blockly/guides/contribute/core/style_guide). + + Thank you for opening this PR! A member of the Blockly team will review it soon. From 509d57e8f74e5552e55cf3c9a113b5c73b8c7238 Mon Sep 17 00:00:00 2001 From: Maribeth Bottorff Date: Wed, 16 Aug 2023 21:48:03 -0700 Subject: [PATCH 2/3] chore: format --- .github/workflows/welcome_new_contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/welcome_new_contributors.yml b/.github/workflows/welcome_new_contributors.yml index 2f5a3a96cc0..4466ceef216 100644 --- a/.github/workflows/welcome_new_contributors.yml +++ b/.github/workflows/welcome_new_contributors.yml @@ -15,7 +15,7 @@ jobs: pr-message: > Welcome! It looks like this is your first pull request in blockly, so here are a couple of tips: - + - You can find tips about contributing to Blockly and how to validate your changes on our [developer site](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change). From 007b6afb5c51e974eca6543bd42e21ead7cf758d Mon Sep 17 00:00:00 2001 From: Maribeth Bottorff Date: Thu, 17 Aug 2023 11:28:10 -0700 Subject: [PATCH 3/3] chore: typo --- .github/workflows/welcome_new_contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/welcome_new_contributors.yml b/.github/workflows/welcome_new_contributors.yml index 4466ceef216..6e598ee4aea 100644 --- a/.github/workflows/welcome_new_contributors.yml +++ b/.github/workflows/welcome_new_contributors.yml @@ -13,7 +13,7 @@ jobs: with: repo-token: ${{ secrets.GITHUB_TOKEN }} pr-message: > - Welcome! It looks like this is your first pull request in blockly, + Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips: - You can find tips about contributing to Blockly and how to