Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All mutators have broken workspace coordinates. #7677

Closed
1 task done
NeilFraser opened this issue Dec 1, 2023 · 2 comments · Fixed by #7690
Closed
1 task done

All mutators have broken workspace coordinates. #7677

NeilFraser opened this issue Dec 1, 2023 · 2 comments · Fixed by #7690
Assignees
@BeksOmega
Labels
component: coordinates component: mutators issue: bug Describes why the code or behaviour is wrong type: regression

Comments

@NeilFraser
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

The root block for all mutators appears over the toolbox. LTR only.

Reproduction steps

  1. Open a mutator bubble.

Stack trace

No response

Screenshots

Screenshot 2023-12-01 at 20 48 12

Browsers

No response
@BeksOmega BeksOmega self-assigned this Dec 1, 2023
@BeksOmega
Copy link
Collaborator

BeksOmega commented Dec 1, 2023 •
edited
Loading

Could not reproduce :/

[Edit: now able to reproduce]

@BeksOmega
Copy link
Collaborator

I /think/ the issue is that I deleted code here because I thought we always update the metrics of the workspace immediately.

But apparently the updating of the metrics is handled by the scrollbars, and mutators don't have scrollbars. Not sure if I'm going to add the code back or actually fix it so the logic doesn't need to go through the scrollbars.

This was referenced Dec 4, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeksOmega BeksOmega

Labels
component: coordinates component: mutators issue: bug Describes why the code or behaviour is wrong type: regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: mutator coordinates not respecting flyout BeksOmega/blockly
2 participants
@NeilFraser @BeksOmega