-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Documentation update - Standardize on uv for package management #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @pemujo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the development workflow documentation by standardizing on Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the contribution guidelines by standardizing on uv for running tests and installing formatting tools, which makes the development setup clearer and more robust. I've provided a couple of suggestions in the CONTRIBUTING.md file to further improve consistency and clarity. Overall, a good documentation update.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Hi @pemujo , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @wyf7107 , can you please review this |
Link to an existing issue (if applicable):
No existing issue since this is only a small change to CONTRIBUTING.md
Problem:
Test Isolation: Step 5 currently instructs users to run pytest directly. This may execute tests using system libraries and versions rather than the project's isolated environment, potentially leading to inconsistent results or unknown issues.
Formatter Detection: In Step 6, autoformat.sh checks for pyink and isort on the system path rather than the active virtual environment. Consequently, the script may fail to detect missing libraries or fail to fix formatting errors even if the tools are installed in the project environment.
Solution:
Updated instructions to use uv run pytest to ensure tests run within the active virtual environment with correct dependency versions.
Added a command to explicitly install/verify isort and pyink via uv before running the autoformatter.
Checklist