Skip to content
This repository was archived by the owner on Apr 7, 2025. It is now read-only.

Commit ae4a6d4

Browse files
committed
Fix version-search pattern in rename_to_version.py
A while ago I made a misguided "improvement" to Version.h to use constexpr instead of const. What could go wrong? Well, it turns out that there were two separate references to the exact format of that line. The upgrade-detection logic looked for 'const float kCurrentVersion' and so did the .zip file renaming logic. The simplest code cleanups can break things.
1 parent c5196b9 commit ae4a6d4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rename_to_version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import os
22
import sys
33

4-
prefix = 'constexpr float kCurrentVersion = '
4+
prefix = 'const float kCurrentVersion = '
55

66
version_header = sys.argv[1]
77
for line in open(version_header).readlines():

0 commit comments

Comments
 (0)