Skip to content

Update deprecated packages to latest versions #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update deprecated packages to latest versions #4904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2416ee3
Update deprecated packages to latest versions per reviewer feedback
ipapapa Aug 29, 2025
69e019b
Fix OAuth2Client type compatibility in CLI package
ipapapa Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
260 changes: 253 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@google/gemini-cli-core": "file:../core",
"@google/genai": "1.13.0",
"@iarna/toml": "^2.2.5",
"@modelcontextprotocol/sdk": "^1.15.1",
"@modelcontextprotocol/sdk": "^1.17.0",
"@types/update-notifier": "^6.0.8",
"command-exists": "^1.2.9",
"diff": "^7.0.0",
Expand All @@ -55,7 +55,8 @@
"undici": "^7.10.0",
"update-notifier": "^7.3.1",
"yargs": "^17.7.2",
"zod": "^3.23.8"
"zod": "^3.23.8",
"google-auth-library": "^10.2.0"
Copy link
Collaborator

@swissspidy swissspidy Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this newly added?

Copy link
Contributor Author

@ipapapa ipapapa Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The google-auth-library dependency was added to packages/cli/package.json to fix a TypeScript compilation error that occurred after the dependency updates, but let me check if removing it would actually not cause an error.

Copy link
Contributor Author

@ipapapa ipapapa Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested removing the google-auth-library dependency from the CLI package and the compilation error returns:

The dependency is needed because:

  • CLI package imports OAuth2Client from google-auth-library in test files
  • Without explicit dependency, it resolves to v9.x (lacks these properties)
  • Core package uses v10.x (has these properties)
  • TypeScript sees two different OAuth2Client types and they're incompatible

},
"devDependencies": {
"@babel/runtime": "^7.27.6",
Expand Down
4 changes: 2 additions & 2 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"dependencies": {
"@google/genai": "1.13.0",
"@lvce-editor/ripgrep": "^1.6.0",
"@modelcontextprotocol/sdk": "^1.11.0",
"@modelcontextprotocol/sdk": "^1.17.0",
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/exporter-logs-otlp-grpc": "^0.203.0",
"@opentelemetry/exporter-logs-otlp-http": "^0.203.0",
Expand All @@ -45,7 +45,7 @@
"fdir": "^6.4.6",
"fzf": "^0.5.2",
"glob": "^10.4.5",
"google-auth-library": "^9.11.0",
"google-auth-library": "^10.2.0",
"html-to-text": "^9.0.5",
"https-proxy-agent": "^7.0.6",
"ignore": "^7.0.0",
Expand Down
Loading
Loading