You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
There is an undocumented and undisplayed error in the code that should be addressed. If an improper name of the ROM is used (for example "Breakout" instead of "breakout"), the program simply crashes with a SEGFAULT leaving the user clueless of what they are doing wrong.
The problem is caused by the buildRomRLWrapper function within the games/Roms.cpp file, where the loop is looking through a list of supported ROMs. If the name isn't matched exactly, the method silently returns NULL, causing a crash down the road.
Here are a couple of proposed solutions:
Make a note in the README files about the list of supported ROMs and their proper naming convention
If possible, make the program output a warning inside the buildRomRLWrapper function before the NULL is returned. Say something like "The ROM XXX isn't supported. Please make sure the name is written correctly!"
Fix this entirely, by asking the user to provide the codename (or some kind of ID) of the game, together with the ROM file, instead of relying on the file name itself - which is a poor practice.
Use md5sum in a hashmap to determine which game ROM it is that you are trying to load
The text was updated successfully, but these errors were encountered:
This bug is regarding the DQN demo provided here.
There is an undocumented and undisplayed error in the code that should be addressed. If an improper name of the ROM is used (for example "Breakout" instead of "breakout"), the program simply crashes with a SEGFAULT leaving the user clueless of what they are doing wrong.
The problem is caused by the buildRomRLWrapper function within the games/Roms.cpp file, where the loop is looking through a list of supported ROMs. If the name isn't matched exactly, the method silently returns NULL, causing a crash down the road.
Here are a couple of proposed solutions:
The text was updated successfully, but these errors were encountered: