Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Problem with running ROMs with improper names #1

Closed
danijel3 opened this issue Mar 2, 2015 · 1 comment · May be fixed by #2
Closed

Problem with running ROMs with improper names #1

danijel3 opened this issue Mar 2, 2015 · 1 comment · May be fixed by #2

Comments

@danijel3
Copy link

danijel3 commented Mar 2, 2015

This bug is regarding the DQN demo provided here.

There is an undocumented and undisplayed error in the code that should be addressed. If an improper name of the ROM is used (for example "Breakout" instead of "breakout"), the program simply crashes with a SEGFAULT leaving the user clueless of what they are doing wrong.

The problem is caused by the buildRomRLWrapper function within the games/Roms.cpp file, where the loop is looking through a list of supported ROMs. If the name isn't matched exactly, the method silently returns NULL, causing a crash down the road.

Here are a couple of proposed solutions:

  1. Make a note in the README files about the list of supported ROMs and their proper naming convention
  2. If possible, make the program output a warning inside the buildRomRLWrapper function before the NULL is returned. Say something like "The ROM XXX isn't supported. Please make sure the name is written correctly!"
  3. Fix this entirely, by asking the user to provide the codename (or some kind of ID) of the game, together with the ROM file, instead of relying on the file name itself - which is a poor practice.
  4. Use md5sum in a hashmap to determine which game ROM it is that you are trying to load
@ghost
Copy link

ghost commented Mar 2, 2015

try using lower case

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant