Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should NOT call viewport while binding texture #5904

Open
whatisor opened this issue Mar 12, 2025 · 1 comment
Open

Should NOT call viewport while binding texture #5904

whatisor opened this issue Mar 12, 2025 · 1 comment
Assignees
Labels
platform:javascript MediaPipe Javascript issues stat:awaiting response Waiting for user response task:image segmentation Issues related to image segmentation: Locate objects and create image masks with labels type:bug Bug in the Source Code of MediaPipe Solution

Comments

@whatisor
Copy link

whatisor commented Mar 12, 2025

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)

None

OS Platform and Distribution

Web

Mobile device if the issue happens on mobile device

No response

Browser and version if the issue happens on browser

No response

Programming Language and version

Typescript

MediaPipe version

master

Bazel version

No response

Solution

Tasks-vision -> ImageSegmenter

Android Studio, NDK, SDK versions (if issue is related to building in Android environment)

No response

Xcode & Tulsi version (if issue is related to building for iOS)

No response

Describe the actual behavior

Calling gl.viewport while binding texture is meaningless. It should be called only when rendering required to avoid affect application code.

Describe the expected behaviour

Bring gl.viewport to outside, to where it needs to render.

Standalone code/steps you may have used to try to get what you need

Other info / Complete Logs

https://github.com/google-ai-edge/mediapipe/blob/70a9f597f342c1875a5080dfbaab50f23ee29fb6/mediapipe/tasks/web/vision/core/mask.ts#L364C5-L364C48
@whatisor whatisor added the type:bug Bug in the Source Code of MediaPipe Solution label Mar 12, 2025
@whatisor whatisor changed the title Should call viewport while binding texture Should NOT call viewport while binding texture Mar 13, 2025
@kuaashish kuaashish added platform:javascript MediaPipe Javascript issues task:image segmentation Issues related to image segmentation: Locate objects and create image masks with labels labels Mar 13, 2025
@kuaashish
Copy link
Collaborator

Hi @whatisor,

Could you please provide more details about the issue? We are having difficulty fully understanding it.

Thank you!!

@kuaashish kuaashish added the stat:awaiting response Waiting for user response label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:javascript MediaPipe Javascript issues stat:awaiting response Waiting for user response task:image segmentation Issues related to image segmentation: Locate objects and create image masks with labels type:bug Bug in the Source Code of MediaPipe Solution
Projects
None yet
Development

No branches or pull requests

2 participants