New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PalmCivet should give two different exceptions #3

Open

ericpromislow opened this issue Mar 5, 2018 · 1 comment

ericpromislow commented Mar 5, 2018

Emit InvalidByteQuantityError for an invalid or missing suffix
Emit InvalidNumericSequence if the value does not start with a number.

RIght now we just get InvalidByteQuantityError for all strings, and then the error messages are incorrect.

The text was updated successfully, but these errors were encountered:

tcdowney commented Mar 28, 2018

This would allow us to avoid doing this:
https://github.com/cloudfoundry/cloud_controller_ng/blob/3a1b20a1098d054e876a23bb1c8a8a9f314ed167/lib/cloud_controller/app_manifest/byte_converter.rb#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment