Fix issue #153: creation/update of root categories (#157)

* chore: release v0.4.3 (#149)

* chore: release v0.4.1-hotfix.3

* fix(data-migration): early return if no categories have parents (#128)

Signed-off-by: Robert Goniszewski <[email protected]>

* Closes #130 (#131)

Signed-off-by: Robert Goniszewski <[email protected]>

* fix(database): use dynamic path for SQLite database file

Signed-off-by: Robert Goniszewski <[email protected]>

* docs(readme): use single README file for latest/preview version

Signed-off-by: Robert Goniszewski <[email protected]>

* feat(ci): add manual deployment workflow and adjust tag conditions

Signed-off-by: Robert Goniszewski <[email protected]>

* refactor(workflow): simplify manual-deploy GitHub Action

Signed-off-by: Robert Goniszewski <[email protected]>

* fix(metadata): handle multiple image URLs in mainImageUrl field

Signed-off-by: Robert Goniszewski <[email protected]>

* fix: auth error handling (#144)

* refactor(api): migrate Swagger UI to external documentation and enhance health endpoint

Signed-off-by: Robert Goniszewski <[email protected]>

* chore: release v0.4.3

---------

Signed-off-by: Robert Goniszewski <[email protected]>
Co-authored-by: Prabhanjan <[email protected]>

* Fix creation/update of root categories

---------

Signed-off-by: Robert Goniszewski <[email protected]>
Co-authored-by: Robert Goniszewski <[email protected]>
Co-authored-by: Prabhanjan <[email protected]>

Author: 3 people

src/lib/components/AddCategoryForm/AddCategoryForm.svelte

@@ -28,25 +28,25 @@
 	let form: HTMLFormElement;
 	export let closeModal: () => void;
 
-	const categoriesOptions = writable<{ value: string; label: string }[]>([
+	const categoriesOptions = writable<{ value: string | null; label: string }[]>([
 		{
-			value: 'null',
+			value: null,
 			label: 'No parent'
 		}
 	]);
 
 	$: {
 		$categoriesOptions = [
 			{
-				value: 'null',
+				value: null,
 				label: 'No parent'
 			},
 			...$page.data.categories
 				.filter((c) => {
 					return c.id !== $category.id;
 				})
 				.map((c) => ({
-					value: c.id,
+					value: c.id.toString(),
 					label: c.name
 				}))
 		];
@@ -224,13 +224,12 @@
 						name="parent"
 						searchable
 						placeholder="Select parent category..."
-						required
-						value={$category.parent?.id || $categoriesOptions[0].value}
+						value={$category.parent?.id?.toString() || $categoriesOptions[0].value}
 						items={$categoriesOptions}
 						class="this-select input input-bordered w-max"
 						on:change={(event) => {
 							// @ts-ignore-next-line
-							$category.parent = $page.data.categories.find((c) => c.id === event.detail.value);
+							$category.parent = $page.data.categories.find((c) => c.id.toString() === event.detail.value);
 						}}
 					/>
 				</div>

src/lib/components/EditCategoryForm/EditCategoryForm.svelte

@@ -16,25 +16,25 @@
 	let form: HTMLFormElement;
 	export let closeModal: () => void;
 
-	const categoriesOptions = writable<{ value: number; label: string }[]>([
+	const categoriesOptions = writable<{ value: string | null; label: string }[]>([
 		{
-			value: 0,
+			value: null,
 			label: 'No parent'
 		}
 	]);
 
 	$: {
 		$categoriesOptions = [
 			{
-				value: 0,
+				value: null,
 				label: 'No parent'
 			},
 			...$page.data.categories
 				.filter((c) => {
 					return c.id !== $category.id;
 				})
 				.map((c) => ({
-					value: c.id,
+					value: c.id.toString(),
 					label: c.name
 				}))
 		];
@@ -214,13 +214,12 @@
 							name="parent"
 							searchable
 							placeholder="Select parent category..."
-							required
-							value={$category.parent?.id || $categoriesOptions[0].value}
+							value={$category.parent?.id?.toString() || $categoriesOptions[0].value}
 							items={$categoriesOptions}
 							class="this-select input input-bordered w-max"
 							on:change={(event) => {
 								// @ts-ignore-next-line
-								$category.parent = $page.data.categories.find((c) => c.id === event.detail.value);
+								$category.parent = $page.data.categories.find((c) => c.id.toString() === event.detail.value);
 							}}
 						/>
 					</div>

src/routes/+page.server.ts

@@ -290,7 +290,7 @@ export const actions = {
 		const description = data.get('description') as string;
 		const icon = data.get('icon') as string;
 		const color = data.get('color') as string;
-		const parent = JSON.parse(data.get('parent') as string);
+		const parent = data.get('parent') ? JSON.parse(data.get('parent') as string) : null;
 		const parentValue = parent?.value ? parent.value : parent;
 		const archived = data.get('archived') === 'on' ? new Date() : null;
 		const setPublic = data.get('public') === 'on' ? new Date() : null;
@@ -301,7 +301,7 @@ export const actions = {
 			description,
 			icon,
 			color,
-			parentId: parentValue === 'null' ? null : parentValue,
+			parentId: parentValue,
 			archived,
 			public: setPublic,
 			ownerId,
@@ -332,7 +332,7 @@ export const actions = {
 		const description = data.get('description') as string;
 		const icon = data.get('icon') as string;
 		const color = data.get('color') as string;
-		const parent = JSON.parse(data.get('parent') as string);
+		const parent = data.get('parent') ? JSON.parse(data.get('parent') as string) : null;
 		const parentValue = parent?.value ? parent.value : parent;
 		const archived = data.get('archived') === 'on' ? new Date() : null;
 		const setPublic = data.get('public') === 'on' ? new Date() : null;
@@ -343,7 +343,7 @@ export const actions = {
 			description,
 			icon,
 			color,
-			parentId: parentValue === 'null' ? null : parentValue,
+			parentId: parentValue,
 			archived,
 			public: setPublic
 		};