Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveness and readiness probes for Kubernetes #891

Closed
arschles opened this issue Nov 9, 2018 · 5 comments · Fixed by #942
Closed

Add liveness and readiness probes for Kubernetes #891

arschles opened this issue Nov 9, 2018 · 5 comments · Fixed by #942
Labels
good first issue Great issues for new Athenians to work on! hosting Work to do to improve/change how we host the services

Comments

@arschles
Copy link
Member

arschles commented Nov 9, 2018

Describe the solution you'd like

The proxy can implement an endpoint that Kubernetes liveness / readiness probes can use to figure out if the proxy is running and healthy.

I think we should implement the endpoint in the proxy and configure the helm chart to use it.

Additional context

I'm researching and preparing for #772 and found that this would be really helpful for us.

@arschles arschles added good first issue Great issues for new Athenians to work on! hosting Work to do to improve/change how we host the services labels Nov 9, 2018
@marpio
Copy link
Member

marpio commented Nov 10, 2018

@arschles we already have the /healthz endpoint. Do we need to modify it somehow or do we need something different additionally?

@ghost
Copy link

ghost commented Nov 12, 2018

I think the /healthz endpoint covers the liveness probe.

I'm uncertain what we would do different for a readiness probe. Maybe an endpoint that checks outgoing network connectivity or backing storage availability.

@manugupt1
Copy link
Member

Would it not be different if you have several proxy server's running and one of them s down, but others are running on the same cluster?

@michalpristas
Copy link
Member

for health, I imagined a sweet stats where we can see how many mods are being served/fetched at the moments so in case we have some smart Load balancer it can be configured to balance the work based on these stats.
network check is a good idea, together with a storage ping, VCS ping maybe, you can be in one cluster on different machines and machine can be somehow messed up and not see storage, vcs etc.

@chriscoffee
Copy link
Member

chriscoffee commented Nov 12, 2018

I usually do something like DNS resolution check and database check on /readiness for readiness. For our case we could probably probe the storage driver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great issues for new Athenians to work on! hosting Work to do to improve/change how we host the services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants