From bb7b2d81a6fbf10de9665adef384f3e3ee4a9dcf Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 4 Apr 2025 15:19:22 +1300 Subject: [PATCH 1/3] fix: update `revive` rules in json schema --- jsonschema/golangci.jsonschema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/jsonschema/golangci.jsonschema.json b/jsonschema/golangci.jsonschema.json index e775096e315b..42ded68acacd 100644 --- a/jsonschema/golangci.jsonschema.json +++ b/jsonschema/golangci.jsonschema.json @@ -630,8 +630,9 @@ "range", "receiver-naming", "redefines-builtin-id", - "redundant-build-tag", "redundant-import-alias", + "redundant-build-tag", + "redundant-test-main-exit", "string-format", "string-of-int", "struct-tag", From bd52a7315134271d4b9d2d20394181397de846f6 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 4 Apr 2025 15:23:09 +1300 Subject: [PATCH 2/3] chore: restore order --- jsonschema/golangci.jsonschema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jsonschema/golangci.jsonschema.json b/jsonschema/golangci.jsonschema.json index 42ded68acacd..591551a7eade 100644 --- a/jsonschema/golangci.jsonschema.json +++ b/jsonschema/golangci.jsonschema.json @@ -630,8 +630,8 @@ "range", "receiver-naming", "redefines-builtin-id", - "redundant-import-alias", "redundant-build-tag", + "redundant-import-alias", "redundant-test-main-exit", "string-format", "string-of-int", From b34db22bdc57a9d34a9f18d0d7db68105851fcaa Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Fri, 4 Apr 2025 04:31:08 +0200 Subject: [PATCH 3/3] review --- .golangci.next.reference.yml | 5 +++++ .golangci.reference.yml | 5 +++++ jsonschema/golangci.next.jsonschema.json | 1 + 3 files changed, 11 insertions(+) diff --git a/.golangci.next.reference.yml b/.golangci.next.reference.yml index 7b9b2a4c39ef..f5e908617715 100644 --- a/.golangci.next.reference.yml +++ b/.golangci.next.reference.yml @@ -2549,6 +2549,11 @@ linters: severity: warning disabled: false exclude: [""] + # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#redundant-test-main-exit + - name: redundant-test-main-exit + severity: warning + disabled: false + exclude: [""] # https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#string-format - name: string-format severity: warning diff --git a/.golangci.reference.yml b/.golangci.reference.yml index 339fe9bcca52..446e06780a00 100644 --- a/.golangci.reference.yml +++ b/.golangci.reference.yml @@ -2546,6 +2546,11 @@ linters: severity: warning disabled: false exclude: [""] + # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#redundant-test-main-exit + - name: redundant-test-main-exit + severity: warning + disabled: false + exclude: [""] # https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#string-format - name: string-format severity: warning diff --git a/jsonschema/golangci.next.jsonschema.json b/jsonschema/golangci.next.jsonschema.json index 90b438dd0068..ff3eaf96cef8 100644 --- a/jsonschema/golangci.next.jsonschema.json +++ b/jsonschema/golangci.next.jsonschema.json @@ -632,6 +632,7 @@ "redefines-builtin-id", "redundant-build-tag", "redundant-import-alias", + "redundant-test-main-exit", "string-format", "string-of-int", "struct-tag",