From ff3219d2005f15c14de54c0cefa3580956a7ba04 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 7 Sep 2023 01:28:35 +0000 Subject: [PATCH 1/2] build(deps): bump github.com/ryanrolds/sqlclosecheck from 0.4.0 to 0.5.1 Bumps [github.com/ryanrolds/sqlclosecheck](https://github.com/ryanrolds/sqlclosecheck) from 0.4.0 to 0.5.1. - [Release notes](https://github.com/ryanrolds/sqlclosecheck/releases) - [Commits](https://github.com/ryanrolds/sqlclosecheck/compare/v0.4.0...v0.5.1) --- updated-dependencies: - dependency-name: github.com/ryanrolds/sqlclosecheck dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index 0f180d2dfc19..9e9c88f81cdc 100644 --- a/go.mod +++ b/go.mod @@ -81,7 +81,7 @@ require ( github.com/polyfloyd/go-errorlint v1.4.4 github.com/quasilyte/go-ruleguard/dsl v0.3.22 github.com/ryancurrah/gomodguard v1.3.0 - github.com/ryanrolds/sqlclosecheck v0.4.0 + github.com/ryanrolds/sqlclosecheck v0.5.1 github.com/sanposhiho/wastedassign/v2 v2.0.7 github.com/sashamelentyev/interfacebloat v1.1.0 github.com/sashamelentyev/usestdlibvars v1.24.0 diff --git a/go.sum b/go.sum index 786283a2597c..535b9b3d6685 100644 --- a/go.sum +++ b/go.sum @@ -456,8 +456,8 @@ github.com/rogpeppe/go-internal v1.10.0 h1:TMyTOH3F/DB16zRVcYyreMH6GnZZrwQVAoYjR github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM= github.com/ryancurrah/gomodguard v1.3.0 h1:q15RT/pd6UggBXVBuLps8BXRvl5GPBcwVA7BJHMLuTw= github.com/ryancurrah/gomodguard v1.3.0/go.mod h1:ggBxb3luypPEzqVtq33ee7YSN35V28XeGnid8dnni50= -github.com/ryanrolds/sqlclosecheck v0.4.0 h1:i8SX60Rppc1wRuyQjMciLqIzV3xnoHB7/tXbr6RGYNI= -github.com/ryanrolds/sqlclosecheck v0.4.0/go.mod h1:TBRRjzL31JONc9i4XMinicuo+s+E8yKZ5FN8X3G6CKQ= +github.com/ryanrolds/sqlclosecheck v0.5.1 h1:dibWW826u0P8jNLsLN+En7+RqWWTYrjCB9fJfSfdyCU= +github.com/ryanrolds/sqlclosecheck v0.5.1/go.mod h1:2g3dUjoS6AL4huFdv6wn55WpLIDjY7ZgUR4J8HOO/XQ= github.com/sanposhiho/wastedassign/v2 v2.0.7 h1:J+6nrY4VW+gC9xFzUc+XjPD3g3wF3je/NsJFwFK7Uxc= github.com/sanposhiho/wastedassign/v2 v2.0.7/go.mod h1:KyZ0MWTwxxBmfwn33zh3k1dmsbF2ud9pAAGfoLfjhtI= github.com/sashamelentyev/interfacebloat v1.1.0 h1:xdRdJp0irL086OyW1H/RTZTr1h/tMEOsumirXcOJqAw= From 86f95300e79993a30280f61a14de699e813a2b2a Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Thu, 7 Sep 2023 10:39:53 +0200 Subject: [PATCH 2/2] chore: update tests --- test/testdata/sqlclosecheck.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/testdata/sqlclosecheck.go b/test/testdata/sqlclosecheck.go index 254bb3d94146..5a5a13f78b6f 100644 --- a/test/testdata/sqlclosecheck.go +++ b/test/testdata/sqlclosecheck.go @@ -68,7 +68,7 @@ func rowsCorrectDefer() { } func rowsMissingClose() { - rows, err := db.QueryContext(ctx, "SELECT name FROM users WHERE age=?", age) // want "Rows/Stmt was not closed" + rows, err := db.QueryContext(ctx, "SELECT name FROM users WHERE age=?", age) // want "Rows/Stmt/NamedStmt was not closed" if err != nil { log.Fatal(err) } @@ -91,7 +91,7 @@ func rowsMissingClose() { } func rowsMissingCloseG[T ~int64](db *sql.DB, a T) { - rows, _ := db.Query("select id from tb") // want "Rows/Stmt was not closed" + rows, _ := db.Query("select id from tb") // want "Rows/Stmt/NamedStmt was not closed" for rows.Next() { // ... } @@ -208,7 +208,7 @@ func stmtCorrectDefer() { func stmtMissingClose() { // In normal use, create one Stmt when your process starts. - stmt, err := db.PrepareContext(ctx, "SELECT username FROM users WHERE id = ?") // want "Rows/Stmt was not closed" + stmt, err := db.PrepareContext(ctx, "SELECT username FROM users WHERE id = ?") // want "Rows/Stmt/NamedStmt was not closed" if err != nil { log.Fatal(err) }